library UX polish 3: sticky offset + delete danger zone#220
Merged
Conversation
…lete Two more from the audit: 1. Sticky status tabs were anchored at top:64 but .site-header is 80px until it collapses on scroll. The 16px overlap (transient during the collapse animation) was a real visual glitch. Pinning to top:80 means a small 16px gap when the header is collapsed but no overlap ever — better than the inverse. 2. "Delete Book" was a big red-outlined pill in the primary action row next to Continue Reading / Mark as read — easy to misclick on a book the user just spent time uploading. Apple HIG says destructive actions should sit far from the primary path and look understated. Moved it out of the action row, into a "danger zone" strip below the chapters list, rendered as a small underlined text-link styled in red rather than a pill button. The confirm dialog stays. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mrviduus
added a commit
that referenced
this pull request
May 5, 2026
…con + CHANGELOG (#221) User audit on the icon "+" affordance: - Hover state was just a faint border colour change — no signal what the button does until you click it. - "Add to collection" popover only listed existing collections; creating a new one meant closing it, walking back to the sidebar, typing the name, then re-opening to assign. Five clicks for a one-step intent. - Big "Delete Book" outline-pill in the danger zone (after #220) was better than the primary-row pill but still louder than the circular "+" sitting nearby — visual hierarchy mismatch. Fixes: - Custom CSS tooltip on icon buttons (.add-to-collection-button--icon and .user-book-detail__delete-icon) reads aria-label, shows after a 250ms hover delay (instant feel without flickering), styled to match the dark/light theme. Skips the 1–2s native title delay entirely. - Popover gains an inline "+ New collection" row that swaps to a small text input + Add button on click, creates the collection AND adds the current book in one round-trip, then closes. Apple Notes pattern. - Delete is now a circular trash icon (lucide-style svg, hand-rolled to avoid pulling another dependency) sized 36×36 to match the "+" icon on the page. Same custom tooltip ("Delete this book"). Same red accent. Confirm dialog stays. CHANGELOG.md updated for everything since 2026-04-26 (PR #203 onward — 17 PRs of library + mobile + cleanup work that was missing entries). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sticky tabs at top:80 (matches site-header height, no overlap during collapse). Delete moved out of primary action row to a small text-link in a danger zone below chapters.