@mrvisser
  • @mrvisser 4876607
    (TenantPaging) Use not() for interacting tenant aliases instead
@mrvisser
  • @mrvisser b40dbae
    (TenantPaging) Reduce memory footprint in config cache
@mrvisser
@mrvisser
  • @mrvisser d28c681
    (InvitingGuests) Review followup
@mrvisser

This was probably just an error waiting to happen, as before it probably just so happened that python-software-properties was installed before the a…

mrvisser commented on pull request oaeproject/Hilary#1224
@mrvisser

@simong I wrote up the process here: https://github.com/oaeproject/Hilary/wiki/Inviting-Guests Let me know if this is what you were looking for.

mrvisser created the oaeproject/Hilary wiki
@mrvisser
mrvisser edited the oaeproject/Hilary wiki
mrvisser edited the oaeproject/Hilary wiki
mrvisser edited the oaeproject/Hilary wiki
mrvisser commented on pull request oaeproject/Hilary#1224
@mrvisser

I tend to default to using underscore where possible to access properties of collections/options as it will gracefully handle "empty" / "null" scen…

mrvisser commented on pull request oaeproject/Hilary#1224
@mrvisser

@simong that bug should be fixed if you update your 3akai-ux branch

@mrvisser
  • @mrvisser cec99f2
    (InvitingGuests) Add email+userId support to setpermissions
mrvisser commented on pull request oaeproject/Hilary#1195
@mrvisser

Sorry, just one more

mrvisser commented on pull request oaeproject/Hilary#1195
@mrvisser

Oops, needs license.

mrvisser commented on pull request oaeproject/Hilary#1195
@mrvisser

I think I had only done this to handle isGlobalAdminServer safer with a falsey check instead of strict false check. There shouldn't be any issue im…

mrvisser commented on pull request oaeproject/Hilary#1224
@mrvisser

Yea that's a UI issue. I'll try and reproduce.

@mrvisser
  • @mrvisser 3540950
    Add munin server to performance environment
@mrvisser
  • @mrvisser 018acd0
    Add munin server to performance environment
@mrvisser
  • @mrvisser df8a254
    (MySearch) Add trailing whitespace back; don't trim whitespace for pr…
@mrvisser

Generally speaking: It clutters the template (like inline styles); and Mixes content with presentation; and They can't be overridden (like inline …

@mrvisser

I'm aware of all that. I was hoping we could address my concern directly which is that it is bad practice.

mrvisser commented on pull request oaeproject/Hilary#1224
@mrvisser

I have a public user "Alice" in the "Cambridge" tenant and a loggedin user "Bob" in the guest tenant. When Alice tries to create a public link and…

mrvisser commented on pull request oaeproject/3akai-ux#4038
@mrvisser

There are a couple visual regressions in the tenant listing: The tenants table headers are no longer shaded in the background and bold The backgro…

mrvisser commented on pull request oaeproject/3akai-ux#4038
@mrvisser

@stuartf please note PR stuartf#6 to support the new tenants search

mrvisser commented on pull request oaeproject/Hilary#1195
@mrvisser

@stuartf please note PR stuartf#3 to add tenant search indexing

mrvisser opened pull request stuartf/Hilary#3
@mrvisser
Use lunr for tenant search indexing
1 commit with 402 additions and 48 deletions
mrvisser opened pull request stuartf/3akai-ux#6
@mrvisser
Use new tenant search endpoint for tenant infinite scroll
1 commit with 3 additions and 3 deletions