Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding modules for Spout support #45

Closed
wants to merge 1 commit into from

Conversation

@joreg
Copy link
Contributor

joreg commented May 21, 2016

for now needs alpha34.103 as it depends on new nodes that come with it. those will be included with beta35

@mrvux

This comment has been minimized.

Copy link
Owner

mrvux commented May 30, 2016

Couple of things:
1/Really could run that in current beta, makes 0 sense to force an alpha upgrade to use it.
2/Design is rather fragile,would be much nicer to have a version without having to pass handles around (double->long->double can be lossy)
3/Sender is not good like that, should be a presenter plugin in order to properly use render path instead of early render as it it now

@joreg

This comment has been minimized.

Copy link
Contributor Author

joreg commented May 30, 2016

/1 yes, only the new plugins are in the alpha already. so i am totally fine with this getting merged only when a beta build comes out. or you decide to also start an alpha branch..
/2 i know you had the same reservation regarding the long handle with the texture-sharing before. i haven't seen it fail so far. can you show a case where it doesn't work?
/3 can you elaborate on that? what is a "presenter plugin"?

@mrvux

This comment has been minimized.

Copy link
Owner

mrvux commented May 31, 2016

1/Well for now the plan is to support 33.7, and there's 0 technical requirement to move to a new alpha/beta. Bit of a pain to force an alpha just for a new node....
2/It's rare but can happen, I've seen lossy issues with handles as doubles. So it has a very low probability, but it still can, which means it will, and generally when you really need it the least eg : deadline)
3/Using ToSharedTexture with handle out causes early render, so should have a plugin that works "as" a render window instead (so the internal graph is not early cut), and really don't even need to show the handle at all except for debug.

@joreg

This comment has been minimized.

Copy link
Contributor Author

joreg commented May 31, 2016

2/ the lossy issues i've seen were only when it was not implemented correctly. now i'd argue it is. but happy to be proven wrong. because of course if we have a case that does not work this has to be fixed.

3/if this stops you from accepting this PR that is fine with me. you can close it then, as i'm afraid i won't have the time to tackle this anytime soon.

@mrvux mrvux closed this May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.