Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indeterminate progress bar #26

Closed
anticafe opened this Issue Mar 2, 2015 · 18 comments

Comments

Projects
None yet
4 participants
@anticafe
Copy link

anticafe commented Mar 2, 2015

Do you have any idea on indeterminate square progressbar? Like the below image.

image

@mrwonderman mrwonderman self-assigned this Mar 2, 2015

@mrwonderman

This comment has been minimized.

Copy link
Owner

mrwonderman commented Mar 2, 2015

Good Morning,
I haven't implemented this yet. But it sounds very interesting. I will definitely look into it. The only thing I'm not sure about is, how to display the indetermination. Should the progress just go round the image? Do you have any suggestions on how should it be displayed?
Thank you very much for the idea
Yannick

@mrwonderman mrwonderman modified the milestone: 1.5.0 Mar 2, 2015

@anticafe

This comment has been minimized.

Copy link
Author

anticafe commented Mar 2, 2015

How about mimic indeterminate animation of new Material Design? (Let jump to Circular section)

@mrwonderman

This comment has been minimized.

Copy link
Owner

mrwonderman commented Mar 6, 2015

That sounds like an ideal way to display it. I looked into it a bit, and the only problem I see so far is, that the implementation would require to fill the progress from lets say 25% done to 50%. Like shown here:

screen shot 2015-03-06 at 14 36 48

At the moment the library has only one possibility to draw a progress. And thats from 0% to a given percentage. So I have to add a new way to do this. But this will also give my the possibility to rewrite some of the big chunk of progress code. I will start working on this today on a new branch.

@mrwonderman

This comment has been minimized.

Copy link
Owner

mrwonderman commented Mar 8, 2015

@anticafe Okay, I've kinda got a solution. Sadly I couldn't implement the nice animation mentioned above. But I was really struggling with this implementation. So I will rewrite loads of the onDraw() code for 1.5.0. I made the animation very basic for the moment. Maybe you have some more ideas on how to enhance it. It's just a very hard thing to do, as I'm using the same code as all my other operations on the canvas. This has the advantage that you still can change things like the colour, width and stuff while the "animation" is running.

You can see how it looks on the image beneath, but for a better look, I exported an apk so, you can try it for yourself: https://drive.google.com/file/d/0BwESwPCuXtw7WkxjYjlUYVQ3eTQ/view?usp=sharing

device-2015-03-08-153207

@anticafe

This comment has been minimized.

Copy link
Author

anticafe commented Mar 10, 2015

@mrwonderman Ha ha, the new indeterminate progress bar looks so good :)
I wish you have an extra option to change the default height of progress bar.

P/S: it seems in indeterminate mode, width means height, and height is width.

@pasca

This comment has been minimized.

Copy link

pasca commented Apr 14, 2015

hi @mrwonderman. Looks good. can push this update for indeterminate progress feature? i download the code on branch indeterminate progress, seem no code changes for that feature.. Thanks!

@mrwonderman

This comment has been minimized.

Copy link
Owner

mrwonderman commented Apr 16, 2015

good morning @pasca, yes you're right. I haven't pushed the changes to the branch yet. I will do so at the weekend because I wanna refactor the code a bit. I will comment again, as soon as I did the push. Thanks for bringing this to my attention!

@tosslife

This comment has been minimized.

Copy link

tosslife commented Apr 28, 2015

i use android studio IDE, can you upload this lib on manven for our ! tanks

@mrwonderman

This comment has been minimized.

Copy link
Owner

mrwonderman commented Apr 28, 2015

@tosslife hi, yes I will do so in a few days (I have to create a ticket at sonatype first..). The plan is that I will maintain 2 repositories. One with the current structure as a "legacy repository", so people who still use the eclipse environment don't have to hassle with the new gradle structure. But this repo will be completely migrated to the new android studio (gradle) structure. Locally I already have the repo done. Maybe I can even push it today, I will see.

@pasca I've got the changes done, but as mentioned above, I will migrate first and then push the changes. Sorry for the delay.

@tosslife

This comment has been minimized.

Copy link

tosslife commented Apr 28, 2015

@mrwonderman tanks very much! hope !!!

@mrwonderman

This comment has been minimized.

Copy link
Owner

mrwonderman commented Apr 29, 2015

@tosslife

This comment has been minimized.

Copy link

tosslife commented Apr 29, 2015

@mrwonderman hi ,error ,theme conflict!!

mrwonderman added a commit that referenced this issue Apr 29, 2015

bugfix #26
removed theme variable from the library
@mrwonderman

This comment has been minimized.

Copy link
Owner

mrwonderman commented Apr 29, 2015

@tosslife try again with the version 1.5.1 please:

compile 'ch.halcyon:squareprogressbar:1.5.1'
@tosslife

This comment has been minimized.

Copy link

tosslife commented Apr 30, 2015

@mrwonderman tank you ! good

@mrwonderman mrwonderman modified the milestones: 1.5.0, 1.6.0 May 9, 2015

@mrwonderman

This comment has been minimized.

Copy link
Owner

mrwonderman commented May 14, 2015

@pasca hi, I just pushed the new code concerning the indeterminate feature to the issue_26_indeterminate branch. It will be part of the 1.6.0 release in mid-June. So I will close this issue as soon as that version is published.

@mrwonderman mrwonderman added the fixed label May 15, 2015

@mrwonderman

This comment has been minimized.

Copy link
Owner

mrwonderman commented Jul 10, 2015

@pasca, @anticafe

version 1.6.0 is available now and with it the indeterminate feature halcyon.ch - squareprogressbar v. 1.6.0. Thank you very much for your feedback. I will close this issue for now.

@pasca

This comment has been minimized.

Copy link

pasca commented Aug 26, 2015

awesome, thanks for this man. going to use it on my project.

@anticafe

This comment has been minimized.

Copy link
Author

anticafe commented Aug 26, 2015

@mrwonderman Thank you again for your hard work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.