Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can make a method getIamgeView for squareprogressbar? #34

Closed
tosslife opened this Issue Jul 1, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@tosslife
Copy link

tosslife commented Jul 1, 2015

i want to use universal-image-loader to loading net picture ,and show progress。
squareprogressbar very nice,but only set local drawable and bitmap;
can you get my idea?

@mrwonderman mrwonderman added the question label Jul 1, 2015

@mrwonderman mrwonderman self-assigned this Jul 1, 2015

@mrwonderman

This comment has been minimized.

Copy link
Owner

mrwonderman commented Jul 1, 2015

Hi @tosslife

Thank you very much for the feedback. I just looked at it in detail and I can give you two different solutions for the problem.

Workaround with the current version

I checked with the Android-Universal-Image-Loader library and there is actually a working example on the repository page. You could use the following code to set the loaded image to the SquareProgressBar:

final SquareProgressBar squareProgressBar = (SquareProgressBar) findViewById(R.id.sprogressbar);
squareProgressBar.setImage(R.drawable.panda);
squareProgressBar.setProgress(50.0);

ImageLoader imageLoader = ImageLoader.getInstance();
imageLoader.init(ImageLoaderConfiguration.createDefault(this));
imageLoader.loadImage("http://halcyon.ch/wp-content/uploads/2015/06/1.png", new SimpleImageLoadingListener() {
        @Override
        public void onLoadingComplete(String imageUri, View view, Bitmap loadedImage) {
            squareProgressBar.setImageBitmap(loadedImage);
        }
    });

So this works perfectly with the current code. But I also see your point, because it would be way easier if the SquareProgressBar could return the ImageView directly.

Getter on the SquareProgressBar (not yet implemented)

To use the one-line solution provided by the Android-Universal-Image-Loader library, you need the ImageView directly:

imageLoader.displayImage(imageUri, imageView);

To make this possible I will include a getter method on the SquareProgressBar class which returns the ImageView. This will be included in the 1.6.0 update which is going live next week.

Is this okay so far? I will push the change to the develop-branch and include it in the next version.

Thanks again
Yannick

@mrwonderman mrwonderman added this to the 1.6.0 milestone Jul 1, 2015

@tosslife

This comment has been minimized.

Copy link
Author

tosslife commented Jul 2, 2015

@mrwonderman tanks very much!!! hope 1.6.0 !
other need control ImageView size ,big picture show not better.

1.6.0 1.6.0 ^^

@mrwonderman

This comment has been minimized.

Copy link
Owner

mrwonderman commented Jul 2, 2015

@tosslife yes, I noticed the problems about big images as well. I found a solution for it earlier this week and just pushed the change to the develop branch (513b45b). So this should be fixed with 1.6.0 too. I will close this issue as soon as the version 1.6.0 published.

mrwonderman pushed a commit that referenced this issue Jul 2, 2015

Yannick Signer
added the possibility to get the ImageView
This adds the possibility to return the ImageView of the
SquareProgressBar. This was requested in #34.
@mrwonderman

This comment has been minimized.

Copy link
Owner

mrwonderman commented Jul 10, 2015

@tosslife

version 1.6.0 is available now and with it the new getter for the ImageView halcyon.ch - squareprogressbar v. 1.6.0. Thank you very much for your feedback. I will close this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.