/nom-sql

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #36

Open
lovasoa opened this Issue Sep 19, 2018 · 3 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lovasoa @ms705
@lovasoa
Copy link
Contributor

lovasoa commented Sep 19, 2018

Currently, when parse fails, the user only gets a very uninformative error string as a result.
It would be nice to have a custom error type with useful functionality , such as knowing where the error happened.
@lovasoa

This comment has been minimized.

Sign in to view
Copy link
Contributor

lovasoa commented Sep 19, 2018

See lovasoa@a0e27ac
@ms705

This comment has been minimized.

Sign in to view
Copy link
Owner

ms705 commented Oct 3, 2018

Yes! I've been meaning to add support for more descriptive syntax errors for a while, but never got around to it. Independently, I believe nom's story for parse error handling has also changed, however, so it might be best do to this alongside a port to nom v4.
@ms705

This comment has been minimized.

Sign in to view
Copy link
Owner

ms705 commented Oct 3, 2018

(Though I like the changed you linked; we can certainly merge that one right away.)

@ms705 ms705 referenced this issue Oct 19, 2018

Open

Development roadmap? #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment