Return early if a directory isn't managed by git #10

Merged
merged 1 commit into from Dec 8, 2016

Conversation

Projects
None yet
2 participants

This makes things much faster for large non-git trees that happen to
have setuptools_git among their indirect requirements. For example,
this takes Launchpad's "python setup.py egg_info" from 16 seconds to 2
seconds for me.

#6 would probably help as well, not to mention optimising the realpath handling so that it doesn't unnecessarily re-stat every path element for every file in your tree, which is a candidate for http://accidentallyquadratic.tumblr.com/ . But this is easy and non-intrusive.

Return early if a directory isn't managed by git
This makes things much faster for large non-git trees that happen to
have setuptools_git among their indirect requirements.  For example,
this takes Launchpad's "python setup.py egg_info" from 16 seconds to 2
seconds for me.
Owner

msabramo commented Dec 8, 2016

Thanks, @cjwatson!

@msabramo msabramo merged commit ed8da08 into msabramo:master Dec 8, 2016

@cjwatson cjwatson deleted the cjwatson:early-return branch Dec 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment