Merge pull request #2 from llipio/master

merging solution llipio#16
msach22 · Apr 27, 2017 · beaddaf · beaddaf
2 parents 9fe3d3a + ffa318c
commit beaddaf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/solutions/16.js b/solutions/16.js
@@ -1,5 +1,5 @@
 //msach22
-// should return true if the input array has duplicant element values
+// should return true if the input array has duplicate values and false if it doesn't
 
 const hasDuplicates = (array) => {
   let map = {};
@@ -12,8 +12,6 @@ const hasDuplicates = (array) => {
   return false;
 }
 
-array = [1,2,3];
-
 module.exports = {
   hasDuplicates
 };
diff --git a/test/16.js b/test/16.js
@@ -5,17 +5,14 @@ const hasDuplicates = duplicates.hasDuplicates;
 describe('check duplicates', () => {
   it('should return true since array has duplicates', () => {
     const array = [1,2,3,3,4];
-    const expected = true;
-    expect(hasDuplicates(array)).eql(expected);
+    expect(hasDuplicates(array)).to.be.true;
   });
   it('should return false because array does not have duplicates', () => {
     const array = [1,2,3,4];
-    const expected = false;
-    expect(hasDuplicates(array)).eql(expected);
+    expect(hasDuplicates(array)).to.be.false;
   });
   it('should return false because array is empty', () => {
     const array = [];
-    const expected = false;
-    expect(hasDuplicates(array)).eql(expected);
+    expect(hasDuplicates(array)).to.be.false;
   });
 });