Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow custom position for the arrow. #4

Merged
merged 5 commits into from Mar 19, 2013

Conversation

Projects
None yet
2 participants
Owner

msadouni commented Mar 19, 2013

  • default position is in the middle (50%)
  • pixels, percents and ems are allowed
@msadouni msadouni Allow custom position for the arrow.
- default position is in the middle (50%)
- pixels, percents and ems are allowed
38b2f82
Owner

msadouni commented Mar 19, 2013

I don't really like the $position-value argument name, I'm open for a better suggestion.

kud commented Mar 19, 2013

Shouldn't be position because you don't know if it's left, right, top, bottom.

Maybe you could still name it "position" but it should have two params. position and value.

Owner

msadouni commented Mar 19, 2013

There already is a $position argument, the first one, which can be either top, right, bottom or left. Then the $position-value indicates where the arrow is placed once it is positioned, and if omitted the arrow goes in the middle.

Maybe $offset could be a better name ?

kud commented Mar 19, 2013

Yep, offset so.

@msadouni msadouni added a commit that referenced this pull request Mar 19, 2013

@msadouni msadouni Merge pull request #4 from msadouni/arrow-position
Allow custom position for the arrow.
53f9c7b

@msadouni msadouni merged commit 53f9c7b into master Mar 19, 2013

@msadouni msadouni deleted the arrow-position branch Mar 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment