From f9f27fa13df9374d4cc0dacdc239cfe4f327f23f Mon Sep 17 00:00:00 2001 From: Michael Santos Date: Wed, 21 Mar 2012 11:39:01 -0400 Subject: [PATCH] Use pattern matches instead of guards --- src/gen_icmp.erl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gen_icmp.erl b/src/gen_icmp.erl index 825d453..8550279 100644 --- a/src/gen_icmp.erl +++ b/src/gen_icmp.erl @@ -171,12 +171,12 @@ handle_cast(Msg, State) -> error_logger:info_report([{cast, Msg}, {state, State}]), {noreply, State}. -handle_info({udp, Socket, Saddr, 0, +handle_info({udp, Socket, {SA1,SA2,SA3,SA4} = Saddr, 0, <<4:4, HL:4, _ToS:8, _Len:16, _Id:16, 0:1, _DF:1, _MF:1, _Off:13, _TTL:8, ?IPPROTO_ICMP:8, _Sum:16, SA1:8, SA2:8, SA3:8, SA4:8, _DA1:8, _DA2:8, _DA3:8, _DA4:8, - Data/binary>>}, #state{pid = Pid, s = Socket} = State) when Saddr == {SA1,SA2,SA3,SA4} -> + Data/binary>>}, #state{pid = Pid, s = Socket} = State) -> Opt = case (HL-5)*4 of N when N > 0 -> N; _ -> 0 @@ -413,14 +413,14 @@ ping_loop(Hosts, Acc, #ping_opt{ {0, Data} end, ping_loop(Hosts -- [Address], [{ok, Address, {{Id, Seq, Elapsed}, Payload}}|Acc], Opt); - {icmp, Socket, Saddr, + {icmp, Socket, {SA1,SA2,SA3,SA4}, <> = Data} when Saddr == {SA1,SA2,SA3,SA4} -> + _/binary>> = Data} -> <<_:8/bytes, Payload/binary>> = Data, DA = {DA1,DA2,DA3,DA4}, ping_loop(Hosts -- [DA], [{{error, code({Type, Code})}, DA, {{Id, Seq}, Payload}}|Acc],