Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Comparing changes

Choose two branches to see what's changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base: 46a177498a
...
compare: 4fbd2d1c06
Checking mergeability… Don't worry, you can still create the pull request.
  • 2 commits
  • 2 files changed
  • 0 commit comments
  • 1 contributor
Showing with 17 additions and 19 deletions.
  1. +8 −13 README.md
  2. +9 −6 bin/gen_verx.escript
View
21 README.md
@@ -55,8 +55,8 @@ environment variables before running the script:
## TESTING EVERYTHING WORKS
-To quickly test everything works, you can try running `bin/verx`, an
-escript that provides a simple command line interface to the verx library.
+To quickly test everything works, try running `bin/verx`, an escript
+that provides a simple command line interface to the verx library.
You'll have to set up the ERL\_LIBS environment variable first, e.g.,
if verx is checked out in ~/src:
@@ -303,8 +303,8 @@ To remove the VM, undefine it:
### SUSPENDING AND RESUMING A DOMAIN
-This example is the Erlang equivalent of a Python script to manipulate a
-running domain. The example is taken from:
+This example provides the Erlang equivalent of a Python script to
+manipulate a running domain. The example was taken from:
<http://www.ibm.com/developerworks/linux/library/l-libvirt/>
@@ -392,11 +392,11 @@ similar to the example in the Ruby libvirt documentation
### SYSTEM CONSOLE
-The VM system console can be accessed from any of the transports.
+The VM system console can be accessed using any of the transports.
% Connect to libvirtd using the Unix socket
1> {ok, Ref} = verx_client:start().
- {ok,{verx_client_unix,<0.43.0>}}
+ {ok,<0.43.0>}
% Open a remote protocol session to the Linux containers hypervisor
2> verx:open(Ref, ["lxc:///", 0]).
@@ -428,7 +428,8 @@ The VM system console can be accessed from any of the transports.
### TAKING A SCREENSHOT
-Here is an example of using the libvirt stream interface.
+An example of using the libvirt stream interface to capture an image of
+the VM console:
-module(ss).
-export([host/1]).
@@ -521,15 +522,9 @@ If there are any errors, read through `bin/gen_remote_protocol.escript`.
## TODO
-* fix broken include paths for bin/verx, include/verx.hrl
-
-* generate verx.hrl from virnetprotocol.c
-
* verx\_client\_tls
* single byte received before packet (works if thrown away)
* verx\_client\_tcp
* gen\_server halts when receiving a tcp\_closed message, causes an
error if the caller does a verx\_client:close/1
-
-* merge the Unix, TCP and TLS transports
View
15 bin/gen_verx.escript
@@ -19,22 +19,22 @@ main([File]) ->
Comment = [
" Copyright (c) 2011-" ++ Date ++ ", Michael Santos <michael.santos@gmail.com>",
" All rights reserved.",
-" ",
+"",
" Redistribution and use in source and binary forms, with or without",
" modification, are permitted provided that the following conditions",
" are met:",
-" ",
+"",
" Redistributions of source code must retain the above copyright",
" notice, this list of conditions and the following disclaimer.",
-" ",
+"",
" Redistributions in binary form must reproduce the above copyright",
" notice, this list of conditions and the following disclaimer in the",
" documentation and/or other materials provided with the distribution.",
-" ",
+"",
" Neither the name of the author nor the names of its contributors",
" may be used to endorse or promote products derived from this software",
" without specific prior written permission.",
-" ",
+"",
" THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS",
" \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT",
" LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS",
@@ -50,7 +50,10 @@ main([File]) ->
License = erl_syntax:comment(Comment),
- Module = erl_syntax:attribute(erl_syntax:atom(module), [erl_syntax:atom(filename:basename(File, ".erl"))]),
+ Module = erl_syntax:attribute(
+ erl_syntax:atom(module),
+ [erl_syntax:atom(filename:basename(File, ".erl"))]
+ ),
Includes = includes(["verx.hrl"]),
% Any hardcoded functions will be included here

No commit comments for this range

Something went wrong with that request. Please try again.