Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix connection.js for use in strict mode #64

Merged
merged 1 commit into from Oct 29, 2013

Conversation

Projects
None yet
2 participants
Contributor

tp commented Oct 29, 2013

When running node with --use_strict one gets this error:

node_modules/ftp/lib/connection.js:650
  function nextDir() {
  ^^^^^^^^
SyntaxError: In strict mode code, functions can only be declared at top level or immediately within another function.
@tp tp Fix connection.js for use in strict mode
When running node with `--use_strict` one gets this error:

```
node_modules/ftp/lib/connection.js:650
      function nextDir() {
      ^^^^^^^^
SyntaxError: In strict mode code, functions can only be declared at top level or immediately within another function.
```
8f0d2a6

@mscdex mscdex added a commit that referenced this pull request Oct 29, 2013

@mscdex mscdex Merge pull request #64 from tp/patch-1
Fix connection.js for use in strict mode
f9d3567

@mscdex mscdex merged commit f9d3567 into mscdex:master Oct 29, 2013

Owner

mscdex commented Oct 29, 2013

Thanks, strict mode is too strict.

@tp tp deleted the tp:patch-1 branch Nov 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment