Don't attempt logging in on a PREAUTH connection #109

Merged
merged 1 commit into from Nov 21, 2012

Conversation

Projects
None yet
2 participants
Contributor

antifuchs commented Sep 22, 2012

Node-imap already correctly recorded state for PREAUTH connections,
but attempted to login anyway, which results in a timeout, as it waits
for the connection to get into a state it can never reach.

Don't attempt logging in on a PREAUTH connection
Node-imap already correctly recorded state for PREAUTH connections,
but attempted to login anyway, which results in a timeout, as it waits
for the connection to get into a state it can never reach.
+ self._login(redo);
+ } else {
+ redo();
+ };
@mscdex

mscdex Sep 22, 2012

Owner

Looks good, except the semi-colon here is unnecessary and the start and end brace for the else should be removed for single line blocks.

@antifuchs

antifuchs Oct 2, 2012

Contributor

Eeek, I don't even know how that semicolon got there. I'll fix it up and push an amended commit.

mscdex added a commit that referenced this pull request Nov 21, 2012

Merge pull request #109 from antifuchs/fix-preauth-connections
Don't attempt logging in on a PREAUTH connection

@mscdex mscdex merged commit d3a366b into mscdex:master Nov 21, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment