From 3c094808551f07dad6fb10f48c21601994adef75 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcel=20Wien=C3=B6bst?= Date: Mon, 10 Jul 2023 18:57:53 +0200 Subject: [PATCH 1/4] start polishing docs --- docs/make.jl | 3 ++- docs/src/library.md | 20 ++++++++++++++++++++ src/gensearch.jl | 2 +- 3 files changed, 23 insertions(+), 2 deletions(-) diff --git a/docs/make.jl b/docs/make.jl index 3e58580..f9aaf86 100644 --- a/docs/make.jl +++ b/docs/make.jl @@ -1,3 +1,4 @@ +push!(LOAD_PATH,"../src/") using Documenter using CausalInference @@ -14,4 +15,4 @@ makedocs(modules = [CausalInference], # Documenter can also automatically deploy documentation to gh-pages. # See "Hosting Documentation" and deploydocs() in the Documenter manual # for more information. -deploydocs(repo = "github.com/mschauer/CausalInference.jl.git") +# deploydocs(repo = "github.com/mschauer/CausalInference.jl.git") diff --git a/docs/src/library.md b/docs/src/library.md index 9c48270..485689f 100644 --- a/docs/src/library.md +++ b/docs/src/library.md @@ -72,3 +72,23 @@ CausalInference.ordered_edges CausalInference.insorted CausalInference.removesorted! ``` + +## Adjustment +```@docs +ancestors +descendants +alt_test_dsep +test_covariate_adjustment +alt_test_backdoor +find_dsep +find_min_dsep +find_covariate_adjustment +find_backdoor_adjustment +find_min_covariate_adjustment +find_min_backdoor_adjustment +find_frontdoor_adjustment +list_dseps +list_covariate_adjustment +list_backdoor_adjustment +list_frontdoor_adjustment +``` diff --git a/src/gensearch.jl b/src/gensearch.jl index 02f48f5..384e0bc 100644 --- a/src/gensearch.jl +++ b/src/gensearch.jl @@ -164,7 +164,7 @@ end """ find_covariate_adjustment(g, X, Y, I = Set{eltype(g)}(), R = setdiff(Set(vertices(g)), X, Y)) -Find a covariate adjustment set `Z` with ``I ⊆ Z subseteq ⊆ R`` for sets of vertices `X` and `Y` in `g`, else return `false`. +Find a covariate adjustment set `Z` with ``I ⊆ Z ⊆ R`` for sets of vertices `X` and `Y` in `g`, else return `false`. Based on the algorithmic approach proposed in https://arxiv.org/abs/1803.00116. """ From 82e4ffa7c345991de6e2c140c359fc3bf230cf39 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcel=20Wien=C3=B6bst?= Date: Mon, 10 Jul 2023 19:13:22 +0200 Subject: [PATCH 2/4] add missing frontdoor_min export --- docs/src/library.md | 4 +++- src/CausalInference.jl | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/src/library.md b/docs/src/library.md index 485689f..b29f1fc 100644 --- a/docs/src/library.md +++ b/docs/src/library.md @@ -5,6 +5,7 @@ ```@docs dsep cpdag +alt_cpdag vskel has_recanting_witness backdoor_criterion @@ -84,9 +85,10 @@ find_dsep find_min_dsep find_covariate_adjustment find_backdoor_adjustment +find_frontdoor_adjustment find_min_covariate_adjustment find_min_backdoor_adjustment -find_frontdoor_adjustment +find_min_frontdoor_adjustment list_dseps list_covariate_adjustment list_backdoor_adjustment diff --git a/src/CausalInference.jl b/src/CausalInference.jl index 80c61c4..5eecbbe 100644 --- a/src/CausalInference.jl +++ b/src/CausalInference.jl @@ -4,7 +4,7 @@ using Graphs.SimpleGraphs using Combinatorics using Base.Iterators -export ancestors, descendants, alt_test_dsep, test_covariate_adjustment, alt_test_backdoor, find_dsep, find_min_dsep, find_covariate_adjustment, find_backdoor_adjustment, find_min_covariate_adjustment, find_min_backdoor_adjustment, find_frontdoor_adjustment, list_dseps, list_covariate_adjustment, list_backdoor_adjustment, list_frontdoor_adjustment +export ancestors, descendants, alt_test_dsep, test_covariate_adjustment, alt_test_backdoor, find_dsep, find_min_dsep, find_covariate_adjustment, find_backdoor_adjustment, find_frontdoor_adjustment, find_min_covariate_adjustment, find_min_backdoor_adjustment, find_min_frontdoor_adjustment, list_dseps, list_covariate_adjustment, list_backdoor_adjustment, list_frontdoor_adjustment export dsep, skeleton, gausscitest, dseporacle, partialcor export unshielded, pcalg, vskel export cpdag, alt_cpdag From ebacd38545ff2546ab41b0e7dbe74662f9c5ac38 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcel=20Wien=C3=B6bst?= Date: Mon, 10 Jul 2023 19:19:43 +0200 Subject: [PATCH 3/4] add min frontdoor test --- test/gensearch.jl | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/gensearch.jl b/test/gensearch.jl index 1d5e216..827b79e 100644 --- a/test/gensearch.jl +++ b/test/gensearch.jl @@ -34,9 +34,10 @@ Yvec = [4] @test find_min_dsep(g1, X, Y) == Set([2,5]) @test find_covariate_adjustment(g1, Xint, Yint) == Set([5,6]) @test find_backdoor_adjustment(g1, X, Y) == Set([5,6]) + @test find_frontdoor_adjustment(g1, X, Y) == Set([2,3,7]) @test find_min_covariate_adjustment(g1, Xvec, Yvec) == Set(5) @test find_min_backdoor_adjustment(g1, Xint, Yvec) == Set(5) - @test find_frontdoor_adjustment(g1, X, Y) == Set([2,3,7]) + @test find_min_frontdoor_adjustment(g1, X, Y) == Set(3) @test Set(list_dseps(g1, Xvec, Y)) == Set([Set([3,6]), Set([2,6]), Set([2,3,6]), Set([3,6,7]), Set([2,6,7]), Set([2,3,6,7]), Set([3,5]), Set([2,5]), Set([2,3,5]), Set([3,5,7]), Set([2,5,7]), Set([2,3,5,7]), Set([3,5,6]), Set([2,5,6]), Set([2,3,5,6]), Set([3,5,6,7]), Set([2,5,6,7]), Set([2,3,5,6,7])]) @test Set(list_covariate_adjustment(g1, X, Yint)) == Set([Set([5,7]), Set([5]), Set([6]), Set([6,7]), Set([5,6]), Set([5,6,7])]) @test Set(list_backdoor_adjustment(g1, Xvec, Yint)) == Set([Set([5]), Set([6]), Set([5,6])]) @@ -67,8 +68,10 @@ Y = Set(8) @test find_covariate_adjustment(g2, X, Y, Set(7), Set([1,2,3,4,5])) == false @test find_covariate_adjustment(g2, X, Y, Set{Int64}(), Set([3,4,5,7])) == Set([3,4,5]) @test find_backdoor_adjustment(g2, X, Y) == Set([1,2,3,4,5]) + @test find_frontdoor_adjustment(g2, X, Y) == Set(7) @test find_min_covariate_adjustment(g2, X, Y) == Set([3,4]) @test find_min_backdoor_adjustment(g2, X, Y) == Set([3,4]) + @test find_min_frontdoor_adjustment(g2, X, Y) == Set(7) @test Set(list_dseps(g2, X, Y, Set{Int64}(), Set{Int64}([3,4,5,7]))) == Set([Set([4, 7, 3]), Set([5, 4, 7]), Set([5, 4, 7, 3])]) @test Set(list_covariate_adjustment(g2, Set([6]), Set([8]), Set(Int[]), setdiff(Set(1:8), [1,2]))) == Set([Set([3,4]), Set([4,5]), Set([3,4,5])]) @test Set(list_backdoor_adjustment(g2, Set([6]), Set([8]), Set(Int[]), setdiff(Set(1:8), [1,2]))) == Set([Set([3,4]), Set([4,5]), Set([3,4,5])]) From b9370c67d2b6baf340bc0135aacccb31e99bd4a8 Mon Sep 17 00:00:00 2001 From: Moritz Schauer Date: Tue, 11 Jul 2023 07:37:34 +0200 Subject: [PATCH 4/4] Reset make.jl --- docs/make.jl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/make.jl b/docs/make.jl index f9aaf86..3e58580 100644 --- a/docs/make.jl +++ b/docs/make.jl @@ -1,4 +1,3 @@ -push!(LOAD_PATH,"../src/") using Documenter using CausalInference @@ -15,4 +14,4 @@ makedocs(modules = [CausalInference], # Documenter can also automatically deploy documentation to gh-pages. # See "Hosting Documentation" and deploydocs() in the Documenter manual # for more information. -# deploydocs(repo = "github.com/mschauer/CausalInference.jl.git") +deploydocs(repo = "github.com/mschauer/CausalInference.jl.git")