New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add force option to try_push() #4

Merged
merged 1 commit into from Jun 28, 2015

Conversation

Projects
None yet
2 participants
@cakirke
Contributor

cakirke commented Jun 14, 2015

Show outdated Hide outdated Throttler.pm
Show outdated Hide outdated t/001Basic.t
@cakirke

This comment has been minimized.

Show comment
Hide comment
@cakirke

cakirke Jun 27, 2015

Contributor

i've reverted to my first pass and added support for checking current value, how does this look ?

Contributor

cakirke commented Jun 27, 2015

i've reverted to my first pass and added support for checking current value, how does this look ?

Show outdated Hide outdated Throttler.pm
@mschilli

This comment has been minimized.

Show comment
Hide comment
@mschilli

mschilli Jun 28, 2015

Owner

Also, can you please rebase your branch against upstream/master and then squash commit your changes, so it ends up being a single commit in the main line? Thanks!

Owner

mschilli commented Jun 28, 2015

Also, can you please rebase your branch against upstream/master and then squash commit your changes, so it ends up being a single commit in the main line? Thanks!

@cakirke

This comment has been minimized.

Show comment
Hide comment
@cakirke

cakirke Jun 28, 2015

Contributor

should be ready to go !!

Contributor

cakirke commented Jun 28, 2015

should be ready to go !!

mschilli added a commit that referenced this pull request Jun 28, 2015

Merge pull request #4 from cakirke/bug-33407
add force option to try_push()

@mschilli mschilli merged commit ec4ffba into mschilli:master Jun 28, 2015

@mschilli

This comment has been minimized.

Show comment
Hide comment
@mschilli

mschilli Jun 28, 2015

Owner

It's been merged, thanks so much for your contribution and patience! :)

Owner

mschilli commented Jun 28, 2015

It's been merged, thanks so much for your contribution and patience! :)

@mschilli

This comment has been minimized.

Show comment
Hide comment
@mschilli

mschilli Jun 28, 2015

Owner

... and uploaded 0.08 to CPAN.

Owner

mschilli commented Jun 28, 2015

... and uploaded 0.08 to CPAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment