New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request aims to reduce warnings #71

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@basbloemsaat

basbloemsaat commented Dec 28, 2015

The distribution has circular references and global variables. These
throw warnings on compile checks, eg

perl -c -Ilib lib/Log/Log4perl/Logger.pm

This is a first step to untangling
those.

It prevents a number of modules to litter the namespace by changing
the use into require: this incurs a penalty at runtime, but because
they are called circular, they will be imported into the namespace
very quickly.

The second is the introduction of a l4p::Global module where global
variables (yuk) reside. Because these variables were littered all
over the place, they caused warnings of themselves. The l4p::Global
does not reference any modules, as not to cause new circ refs.

Using globals may very well be necessary, considering the performance
is of utmost importance with logging.

Pull request aims to reduce warnings
The distribution has circular references and global variables. These
throw warnings on compile checks. This is a first step to untangling
those.

It prevents a number of modules to litter the namespace by changing
the use into require: this incurs a penalty at runtime, but because
they are called circular, they will be imported into the namespace
very quickly.

The second is the introduction of a l4p::Global module where global
variables (yuk) reside. Because these variables were littered all
over the place, they caused warnings of themselves. The l4p::Global
does not reference any modules, as not to cause new circ refs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment