New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`use_ok` tests in its own script #18

Merged
merged 2 commits into from Feb 7, 2018

Conversation

Projects
None yet
2 participants
@zakame
Contributor

zakame commented Feb 7, 2018

This PR is a submission for my CPAN Pull Request Challenge this month.

Building on #13, this moves use_ok tests to its own test script, so that it can fail early (the new test runs before others,) and it can try to avoid issues using certain modules like Date::Manip having special initialization.

zakame added some commits Feb 7, 2018

Put `use_ok` tests for dist in its own script
Fail early for errors when compiling this dist's modules.  This also
reduces false positives by just invoking `use_ok` for this dist's
modules only; a simple `use` is fine for the other modules this dist
depends on.
Simply `use` modules in other test scripts
Since there is now a separate `00-compile.t` script to test for
`use_ok`, the other tests can now just `use` the module they need.  This
also prevents issues with e.g. Date::Manip, which has a rather odd
initialization (it `eval()`s backend modules into itself, which I
suspect trips up `use_ok` tests, which does eval tricks of its own.)

@mschout mschout merged commit f72dc0f into mschout:master Feb 7, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zakame zakame deleted the zakame:use_ok-tests-in-its-own-script branch Feb 7, 2018

@zakame

This comment has been minimized.

Contributor

zakame commented Feb 7, 2018

Thanks again! 👍 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment