New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libresonic support? #14

Closed
anarcat opened this Issue Jun 27, 2017 · 8 comments

Comments

Projects
None yet
2 participants
@anarcat
Contributor

anarcat commented Jun 27, 2017

Hi,

I have modified this container to work with libresonic as well, in my libresonic branch. I am not sure how to deal with this - i guess I could just keep my repository for libresonic and keep your for subsonic? or would you like to maintain a branch for libresonic? how do we deal with such things in docker normally?

notice how I dropped the startup.sh script. it's partly out of laziness: i didn't want to figure out which flags are supported by libresonic. but it also seems a lot simpler and allows users to pass their own arguments directly on the commandline without having to convert them. upstream documentation then applies directly...

@mschuerig

This comment has been minimized.

Owner

mschuerig commented Jun 27, 2017

Hi anarcat,

I wasn't aware of libresonic until now and after a first look, I may even start to use it myself instead of subsonic. However, I'll have to look into it more thoroughly and it can take some time, possibly two weeks, until I get to it.

@anarcat

This comment has been minimized.

Contributor

anarcat commented Jun 27, 2017

that's nice to hear!

@mschuerig

This comment has been minimized.

Owner

mschuerig commented Jul 5, 2017

Hi anarcat,

I've had a look at your changes for libresonic. Right now I won't do anything with them. But over time the most likely outcome is that I stop maintaining the subsonic docker image and switch to your libresonic version.

@anarcat

This comment has been minimized.

Contributor

anarcat commented Jul 5, 2017

alright! i don't use it myself either, to be honest. ;) but i will within the next few weeks and I'll let you know how it goes!

@anarcat

This comment has been minimized.

Contributor

anarcat commented Aug 21, 2017

FWIW, i switched to libresonic and then to airsonic. the airsonic branch here refactors the Dockerfile to make it easier to switch between the (!) 3:

https://github.com/anarcat/subsonic-docker-image/tree/airsonic

notice how everything is set on top of the file for easier modification...

@anarcat

This comment has been minimized.

Contributor

anarcat commented Sep 4, 2018

ping?

@mschuerig

This comment has been minimized.

Owner

mschuerig commented Sep 4, 2018

I'm sorry to say that I'm currently not using subsonic or similar anymore. Please just go ahead with your fork.

@anarcat

This comment has been minimized.

Contributor

anarcat commented Sep 4, 2018

@mschuerig thanks for the update. I've created https://github.com/anarcat/docker-airsonic for the future, thanks for your work!

@anarcat anarcat closed this Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment