maxlength in textfield #404

Merged
merged 3 commits into from Jan 9, 2017

Projects

None yet

3 participants

@tomicasoft
Contributor

Hello,
this is my first time in GitHub.
I extended the textfield with maxlength and hope it is ok. #

tomicasoft added some commits Jan 6, 2017
@tomicasoft tomicasoft new attribute maxlength in textfield 0be73ca
@tomicasoft tomicasoft repair formatting of the document for better merge
d344e21
@coveralls

Coverage Status

Coverage increased (+0.0002%) to 99.649% when pulling d344e21 on tomicasoft:master into feda5f6 on mseemann:master.

@mseemann
Owner
mseemann commented Jan 7, 2017

hi, thx for your contribution! Please a test that the maxlength attr is set in the underlaying input element. an example is the testcase for the required attribute in mdl-textfield.component.spec.ts. thx!

tomica test for maxlength added
5f369ac
@coveralls

Coverage Status

Coverage increased (+0.0002%) to 99.649% when pulling 5f369ac on tomicasoft:master into feda5f6 on mseemann:master.

@tomicasoft
Contributor

I have added the test.
Tell me if i have to do some more for this attribute :-D

@mseemann
Owner
mseemann commented Jan 9, 2017

perfect! Thx a lot!

@mseemann mseemann merged commit 0c4406f into mseemann:master Jan 9, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0002%) to 99.649%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment