Add timestamp support #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type implements MsgPack Timestamp specification with following utilities: * Arithmatic operations like System.DateTime. * Basic string conversion. Currently, exact parsing and ISO styles are only supported. * Date/time components properties like System.DateTime. * Type conversion between System.DateTime and System.DateTimeOffset.
These are borrowed from the PR of Timestamp spec, but they looks UInt64.MaxValue and UInt64.MaxValue * -1.
.NET Standard 2.0 does no support RuntimeType serialization, so this feature is not available in .net core. In addition, this feature is not very important because runtime serialization (binary formatter) is legacy for .net core.
yfakariya
force-pushed
the
wip/timestamp
branch
from
78c77f4 to
1f41955
Compare
yfakariya
force-pushed
the
wip/timestamp
branch
from
1f41955 to
fb1d99b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add new msgpack timestamp data type support.
Note that there is a breaking change that default
DateTime,DateTimeOffset, andFILETIMEserialization use timestamp instead of "native ticks".