test faild php 7.2.3

[mhf-ir]

TEST RESULT SUMMARY
---------------------------------------------------------------------
Exts skipped    :    0
Exts tested     :   15
---------------------------------------------------------------------

Number of tests :  115               115
Tests skipped   :    0 (  0.0%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :    5 (  4.3%) (  4.3%)
Expected fail   :    0 (  0.0%) (  0.0%)
Tests passed    :  110 ( 95.7%) ( 95.7%)
---------------------------------------------------------------------
Time taken      :    5 seconds
=====================================================================

Object test, __autoload [tests/019.phpt]
broken random data test [tests/040.phpt]
broken random data test : MessagePack class [tests/040b.phpt]
broken random data test : MessagePackUnpacker::feed [tests/040c.phpt]
broken random data test : MessagePackUnpacker::execute [tests/040d.phpt]

Env:

=====================================================================
PHP         : /usr/bin/php7.2 
PHP_SAPI    : cli
PHP_VERSION : 7.2.3-1+ubuntu16.04.1+deb.sury.org+1
ZEND_VERSION: 3.2.0
PHP_OS      : Linux - Linux bb9855519dff 4.4.0-116-generic #140-Ubuntu SMP Mon Feb 12 21:23:04 UTC 2018 x86_64
INI actual  : /tmp/msgpack-2.0.2/tmp-php.ini
More .INIs  :   
---------------------------------------------------------------------
PHP         : /usr/bin/phpdbg7.2 
PHP_SAPI    : phpdbg
PHP_VERSION : 7.2.3-1+ubuntu16.04.1+deb.sury.org+1
ZEND_VERSION: 3.2.0
PHP_OS      : Linux - Linux bb9855519dff 4.4.0-116-generic #140-Ubuntu SMP Mon Feb 12 21:23:04 UTC 2018 x86_64
INI actual  : /tmp/msgpack-2.0.2/tmp-php.ini
More .INIs  : 
---------------------------------------------------------------------
CWD         : /tmp/msgpack-2.0.2
Extra dirs  : 
VALGRIND    : Not used
=====================================================================
TIME START 2018-03-26 10:50:20

[faabiosr]

any news?

[andypost]

I'm getting similar results for latest version in docker building with Alpinelinux

=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
Unserialize invalid random data [tests/034.phpt]
broken random data test [tests/040.phpt]
broken random data test : MessagePack class [tests/040b.phpt]
broken random data test : MessagePackUnpacker::feed [tests/040c.phpt]
broken random data test : MessagePackUnpacker::execute [tests/040d.phpt]
=====================================================================

but on travis only last 4 fails https://travis-ci.org/alpinelinux/aports/builds/470804570

[andypost]

btw the same tests fail on travis here https://travis-ci.org/msgpack/msgpack-php/jobs/470439899

[andypost]

This commit helped 7c1eb7f

[andypost]

Aarch64 build fails with PHP 7.2
https://build.alpinelinux.org/buildlogs/build-edge-aarch64/community/php7-pecl-msgpack/php7-pecl-msgpack-2.0.3-r1.log

FAILED TEST SUMMARY
---------------------------------------------------------------------
Profiling perf test. [tests/035.phpt]

[andypost]

Considered by test the good speed is 400 https://github.com/msgpack/msgpack-php/blob/master/tests/035.phpt#L25

[~/aports/community/php7-pecl-msgpack]$ cat src/msgpack-2.0.3/tests/035.diff 
001+ 4000 iterations took 49.310209 seconds: 81/s (BAD)
001- %d iterations took %f seconds: %d/s (GOOD)

[andypost]

arm-v7 reports https://build.alpinelinux.org/buildlogs/build-edge-armv7/community/php7-pecl-msgpack/php7-pecl-msgpack-2.0.3-r1.log

FAILED TEST SUMMARY
---------------------------------------------------------------------
Check for double serialisation [tests/005.phpt]
Unserialize invalid data [tests/030.phpt]
Check for double NaN, Inf, -Inf, 0, and -0 [tests/041.phpt]
Check for array unserialization [tests/050.phpt]
Check for buffered streaming unserialization [tests/060.phpt]
Check for unbuffered streaming unserialization [tests/061.phpt]
Check for buffered streaming unserialization (single) [tests/064.phpt]
Check for unbuffered streaming unserialization (single) [tests/065.phpt]
Check for alias functions [tests/070.phpt]
Check for class methods [tests/071.phpt]
Check for class methods unpacker [tests/072.phpt]
Check for class unpacker [tests/073.phpt]
disabled php only (ini_set) [tests/080.phpt]
disabled php only for class methods (ini_set) [tests/081.phpt]
disabled php only for class methods unpacker (ini_set) [tests/082.phpt]
disabled php only for class unpacker (ini_set) [tests/083.phpt]
disabled php only for class methods (constract) [tests/084.phpt]
disabled php only for class methods unpacker (constract) [tests/085.phpt]
disabled php only for class unpacker (constract) [tests/086.phpt]
disabled php only for class methods (set option) [tests/087.phpt]
disabled php only for class methods unpacker (set option) [tests/088.phpt]
disabled php only for class unpacker (set option) [tests/089.phpt]
unpack of object converter (string) [tests/090.phpt]
unpack of object converter (object) [tests/091.phpt]
unpack of object converter (string: php_only=0) [tests/092.phpt]
unpack of object converter (object: php_only=0) [tests/093.phpt]
unpack of object converter : class unpack (object) [tests/095.phpt]
unpack of object converter : class unpack (string: php_only=0) [tests/096.phpt]
unpack of object converter : class unpack (object: php_only=0) [tests/097.phpt]
unpack of object converter: class unpack (string: OPT_PHPONLY=false) [tests/098.phpt]
unpack of object converter : class unpacker (string) [tests/099.phpt]
unpack of object converter : class unpacker (object) [tests/100.phpt]
unpack of object converter : class unpacker (string: php_only=0) [tests/101.phpt]
unpack of object converter : class unpacker (object: php_only=0) [tests/102.phpt]
unpack of object converter: class unpacker (string: OPT_PHPONLY=false) [tests/103.phpt]

[andypost]

With new beta ot fails on ppc64le arch https://gitlab.alpinelinux.org/andypost/aports/-/jobs/24918

[m6w6]

This is really a silly test, which may fail in a slow environment.

[cpaelzer]

@m6w6 I agree, we've hit the Fails of Profiling perf test. [tests/035.phpt] in Ubuntu arm64 and armhf builders and after checking I found that it works ~100% on huge (>16 fast CPUs) systems ~90% on medium systemd (4-8 mid grade CPUs) and 0% when run with some serious background load.

I'm going to try masking the test in our builds because as-is it is causing more trouble than helping.

[andypost]

Just to note for 2.1.2 version on ppc64le (Alpinelinux) I'm getting

TEST 38/136 [tests/035.phpt]
========DIFF========
001+ 4000 iterations took 10.359318 seconds: 386/s (BAD)
001- %d iterations took %f seconds: %d/s (GOOD)
========DONE========
FAIL Profiling perf test. [tests/035.phpt] 

[m6w6]

We should really disable this test by default...

[andypost]

Maybe just allow to fail?

[m6w6]

AFAIK, a test cannot be marked to be allowed to fail... 🤷‍♂️ We could replace GOOD with %s, though.