-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pure Python (2.*) fallback #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bas Westerbaan <bas@westerbaan.name>
Signed-off-by: Bas Westerbaan <bas@westerbaan.name>
This increases performance *a lot* on PyPy. Signed-off-by: Bas Westerbaan <bas@westerbaan.name>
Very thanks to this PR! |
Increases performance on PyPy.
Signed-off-by: Bas Westerbaan <bas@westerbaan.name>
Signed-off-by: Bas Westerbaan <bas@westerbaan.name>
Signed-off-by: Bas Westerbaan <bas@westerbaan.name>
See next commit. This reverts commit 770fed6.
Thanks for the improvements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several cases where the Cython module cannot be used.
For those cases it is useful to have a pure python implementation of
msgpack
.I could release this as a separate project, but I prefer it merged upstream: it will be easier to keep the API the same.
There is another project which implements msgpack in pure Python, ( keisukefukuda/msgpack-python-pure ) but that is not a drop-in replacement.
Notes
msgpack
will first try to import the native module. If none is available, it will use the fallback.A benchmark
As a very rough benchmark, I timed the pack and unpack time of a 30MB msgpack file from one of my applications.