New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SEGV that will happen with MRI 2.4.0 because of unification of Fixnum and Bignum into Integer #115

Merged
merged 2 commits into from May 25, 2016

Conversation

Projects
None yet
2 participants
@frsyuki
Member

frsyuki commented May 25, 2016

MRI 2.4 will unify rb_cFixnum and rb_cBignum into rb_cInteger (rb_cFixnum == rb_cBignum). But underlaying implementation still require different function calls (FIXNUM_P / RBIGNUM_POSITIVE_P) depending on size of the integer. Thus msgpack-ruby needs to check difference using FIXNUM_P on runtime.
ruby/ruby@f9727c1

@tagomoris

This comment has been minimized.

Show comment
Hide comment
@tagomoris

tagomoris May 25, 2016

Member

LGTM

Member

tagomoris commented May 25, 2016

LGTM

@frsyuki frsyuki merged commit 8059bfd into master May 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@frsyuki frsyuki deleted the mri-24-integer branch May 25, 2016

@frsyuki

This comment has been minimized.

Show comment
Hide comment
@frsyuki

frsyuki May 25, 2016

Member

Merged.

Member

frsyuki commented May 25, 2016

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment