Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe deprecate ujson? #263

Closed
msiemens opened this issue May 17, 2019 · 3 comments

Comments

@msiemens
Copy link
Owner

@msiemens msiemens commented May 17, 2019

ujson's last commit was in March 2017, it seems unmaintained, it seems to leak memory in some circumstances and is not drop-in compatible with Python's json. I think we shouldn't advise its use any more and consider removing official support for it in a future version and deprecate it for now.

What do you think @eugene-eeo?

@msiemens msiemens changed the title Maybe deprecate `ujson`? Maybe deprecate ujson? May 17, 2019
@msiemens

This comment has been minimized.

Copy link
Owner Author

@msiemens msiemens commented May 17, 2019

Maybe python-rapidjson could serve as an alternative if needed although it doesn't seem to support Python 2

@jayvdb

This comment has been minimized.

Copy link

@jayvdb jayvdb commented May 17, 2019

While it isnt maintained in the repo, distros have been applying patches.

I would recommend using mujson, except it doesn't have a test suite yet. See mattgiles/mujson#2

@eugene-eeo

This comment has been minimized.

Copy link
Contributor

@eugene-eeo eugene-eeo commented May 18, 2019

@msiemens yeah, I think dropping support for it officially would be better, since we don't really know what's going on with ujson. If needed, users can write their own storage layer over ujson. The newer kid on the block seems to be orjson but I'm not sure whether it offers comparable features to Python's stdlib json.

@msiemens msiemens closed this in f589310 Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.