New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Query.path to Query._path #107

Merged
merged 1 commit into from Jun 27, 2016

Conversation

2 participants
@joshuahhh
Contributor

joshuahhh commented Jun 27, 2016

I don't know how common it is to have a field called path in your database, but that's the situation I found myself in today, and I got mightily confused when Query().path == 'some/path' returned False instead of giving me a query object! It must be less likely to have a field called _path, so this should prevent some confusing collisions.

PTAL. Thanks!

Rename Query.path to Query._path
I don't know how common it is to have a field called `path` in your database, but that's the situation I found myself in today, and I got mightily confused when `Query().path == 'some/path'` returned `False` instead of giving me a query object! It must be less likely to have a field called `_path`, so this should prevent some confusing collisions.

PTAL. Thanks!

@msiemens msiemens merged commit 8c3eeec into msiemens:master Jun 27, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.742%
Details
@msiemens

This comment has been minimized.

Show comment
Hide comment
@msiemens

msiemens Jun 27, 2016

Owner

Thanks for the PR, @joshuahhh!

Owner

msiemens commented Jun 27, 2016

Thanks for the PR, @joshuahhh!

@msiemens

This comment has been minimized.

Show comment
Hide comment
@msiemens

msiemens Jun 29, 2016

Owner

FYI, I've just released v3.2.1 which includes your fix :)

Owner

msiemens commented Jun 29, 2016

FYI, I've just released v3.2.1 which includes your fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment