New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove absolute imports to support vendoring #142

Merged
merged 2 commits into from Jun 23, 2017

Conversation

2 participants
@mottosso
Contributor

mottosso commented Jun 22, 2017

Hi folks,

Thanks for this amazing project! I'm looking to bundle tinydb with another software library but couldn't due to the global references to tinydb in import statements.

This PR makes all imports relative, so that you can now do this.

from my_library.vendor import tinydb

Let me know if there are any issues.

@msiemens

This comment has been minimized.

Show comment
Hide comment
@msiemens

msiemens Jun 22, 2017

Owner

One small nit with the docstring, otherwise looks good to me!

Owner

msiemens commented Jun 22, 2017

One small nit with the docstring, otherwise looks good to me!

@msiemens msiemens merged commit b2039b7 into msiemens:master Jun 23, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.748%
Details
@msiemens

This comment has been minimized.

Show comment
Hide comment
@msiemens

msiemens Jun 23, 2017

Owner

Merged, thanks! I'll try to find to release a new version of TinyDB next week :)

Owner

msiemens commented Jun 23, 2017

Merged, thanks! I'll try to find to release a new version of TinyDB next week :)

@msiemens

This comment has been minimized.

Show comment
Hide comment
@msiemens

msiemens Jun 27, 2017

Owner

BTW, I've just released v3.3.1 which includes this pull request :)

Owner

msiemens commented Jun 27, 2017

BTW, I've just released v3.3.1 which includes this pull request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment