New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid installing tests as a package. #195

Merged
merged 1 commit into from Mar 21, 2018

Conversation

3 participants
@tarcisioe

tarcisioe commented Mar 21, 2018

Fixes #194

@msiemens msiemens merged commit 5d2b4f5 into msiemens:master Mar 21, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@msiemens

This comment has been minimized.

Owner

msiemens commented Mar 21, 2018

Thanks for the pull request! 🙂

@msiemens

This comment has been minimized.

Owner

msiemens commented Mar 21, 2018

I'll try to get to releasing a new version of TinyDB next week

@tarcisioe tarcisioe deleted the tarcisioe:dont-install-tests branch Mar 21, 2018

@msiemens

This comment has been minimized.

Owner

msiemens commented Mar 26, 2018

Released in v3.8.1 now

@tarcisioe

This comment has been minimized.

tarcisioe commented Mar 26, 2018

The wheel distributed on PyPI still has the tests module. I tried running python setup.py bdist_wheel --universal on my own clone of the repository and it was created correctly. Maybe it was generated against an unclean directory?

@msiemens

This comment has been minimized.

Owner

msiemens commented Mar 27, 2018

Sorry, my bad! Yes, I didn't clean the build/ directory. Now v3.8.1.post1 is released which actually fixes the problem 🙂 Just upgrading to the lastest verison of TinyDB shold install it

@arunpersaud

This comment has been minimized.

arunpersaud commented Apr 6, 2018

Is there a way to still keep the tests files in the tar-ball (they are missing in the 3.8.1post1)? Would be nice to be able to run them before doing setup.py install (they shouldn't get installed though I guess).

@msiemens

This comment has been minimized.

Owner

msiemens commented Apr 7, 2018

Is there a way to still keep the tests files in the tar-ball (they are missing in the 3.8.1post1)? Would be nice to be able to run them before doing setup.py install (they shouldn't get installed though I guess).

I'd be open to that. In my other Python open source project, PyGitUp, tests are included inside the package (in PyGitUp/tests after installation). We could opt for something like this too. @eugene-eeo Do you have an opinion on that?

@arunpersaud

This comment has been minimized.

arunpersaud commented Apr 11, 2018

I haven't really done much packaging, but can't one just write a MANIFEST file that includes the tests, which would mean they get included into the tar-ball, but when running setup.py install they wouldn't be installed?

msiemens added a commit that referenced this pull request Apr 17, 2018

@msiemens

This comment has been minimized.

Owner

msiemens commented Apr 17, 2018

This should work. I've added a MANIFEST.in file, the next release of TinyDB should include tests but not install them 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment