New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added close method to CachingMiddleware. #39

Merged
merged 1 commit into from Nov 7, 2014

Conversation

2 participants
@fokinpv
Contributor

fokinpv commented Nov 7, 2014

Seems there is missing method for the CachingMiddleware.
And with using of JSONStorage db.close() and 'with' section doesn't work correctly for me.

msiemens added a commit that referenced this pull request Nov 7, 2014

Merge pull request #39 from fokinpv/fix-caching-json-close
Added close method to CachingMiddleware.

@msiemens msiemens merged commit 9abae40 into msiemens:master Nov 7, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@msiemens

This comment has been minimized.

Show comment
Hide comment
@msiemens

msiemens Nov 7, 2014

Owner

You're right. Thanks for spotting and fixing this!

Owner

msiemens commented Nov 7, 2014

You're right. Thanks for spotting and fixing this!

@fokinpv fokinpv deleted the fokinpv:fix-caching-json-close branch Nov 7, 2014

@fokinpv fokinpv restored the fokinpv:fix-caching-json-close branch Nov 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment