New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parameters in custom test functions #64

Merged
merged 1 commit into from Jul 4, 2015

Conversation

2 participants
@lordjabez
Contributor

lordjabez commented Jun 29, 2015

This is to address issue #63.

Show outdated Hide outdated tests/test_queries.py
@msiemens

This comment has been minimized.

Show comment
Hide comment
@msiemens

msiemens Jun 30, 2015

Owner

There's a tiny mistake in a test, but otherwise it looks good!

Owner

msiemens commented Jun 30, 2015

There's a tiny mistake in a test, but otherwise it looks good!

@lordjabez

This comment has been minimized.

Show comment
Hide comment
@lordjabez

lordjabez Jun 30, 2015

Contributor

Should I just remove that test? I only included the string comparison because there was a similar one for the previous test case.

Contributor

lordjabez commented Jun 30, 2015

Should I just remove that test? I only included the string comparison because there was a similar one for the previous test case.

@lordjabez

This comment has been minimized.

Show comment
Hide comment
@lordjabez

lordjabez Jun 30, 2015

Contributor

Ahh, I see the issue now. I'll simply remove the test.

Contributor

lordjabez commented Jun 30, 2015

Ahh, I see the issue now. I'll simply remove the test.

msiemens added a commit that referenced this pull request Jul 4, 2015

Merge pull request #64 from lordjabez/feature/arbitrary-parameters-fo…
…r-custom-test

Allow parameters in custom test functions

@msiemens msiemens merged commit 10a93cd into msiemens:master Jul 4, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment