Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dts: add Samsung SM-T533 #13

Closed
wants to merge 1 commit into from
Closed

Conversation

@rvlander
Copy link
Contributor

rvlander commented Mar 1, 2020

This adds Samsung SM-T533 (Samsung Galaxy Tab 4 10.1 (2015), to dts.
I can compile, flash on my device and it seems to work.

However, I have some doubts:

  • I think the codename is matissewifive-eur-r00 but I am not sure (I don't have the original Android installed on my tablet)
  • I used dts files related to this codename in the downstream kernel
  • In the downstream files: some property are set differently to the file I plugged in:
    • qcom,msm-id = <206 0> instead of 247
    • qcom,board-id = <0xF708FF01 0> instead of 7 for the second cell
  • I am not sure if these differences are important
@rvlander rvlander force-pushed the rvlander:st533 branch 3 times, most recently from efa4159 to 651f345 Mar 1, 2020
dts/apq8016-samsung-r02.dts Outdated Show resolved Hide resolved
dts/apq8016-samsung-r02.dts Outdated Show resolved Hide resolved
dts/apq8016-samsung-r02.dts Outdated Show resolved Hide resolved
@rvlander rvlander force-pushed the rvlander:st533 branch from 651f345 to 3c10a99 Mar 1, 2020
dts/apq8016-samsung-r02.dts Outdated Show resolved Hide resolved
@Minecrell Minecrell changed the title WIP: dts: add Samsung SM-T533 dts: add Samsung SM-T533 Mar 1, 2020
@rvlander rvlander force-pushed the rvlander:st533 branch from 3c10a99 to d7d29a6 Mar 1, 2020
@Minecrell

This comment has been minimized.

Copy link
Member

Minecrell commented Mar 1, 2020

Applied to master, thanks again! (I have changed the commit message slightly, otherwise it's the same...)

@Minecrell Minecrell closed this Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.