dts: msm8953: add panel support for zenfone3 #392
Conversation
| qcom,mdss_dsi_tm5p5_r63350_1080p_video { | ||
| compatible = "asus,tm5p5_r63350"; | ||
| }; | ||
|
|
||
| qcom,mdss_dsi_tm5p2_r63350_1080p_video { |
There was a problem hiding this comment.
Considering that they are two different phones (5.5 display and 5.2 display), are there any other differences or the display is the only one, and we can expect the hardware design to be the same? If not, I'd say we should probably split this into two nodes and use match-display here to separate 5.5 and 5.2...
There was a problem hiding this comment.
I taken this one from the LineageOS kernel, and their only differences AFAIK are the display and the battery.
https://wiki.lineageos.org/devices/zenfone3/
Uh looking at the source again, there seems more than one "if 5.2 then, if 5.5 then"...
There was a problem hiding this comment.
@TravMurav there are about eight variants for each screen size...
https://github.com/LineageOS/android_kernel_asus_msm8953/blob/d4ab72afd66672e7b3e49378e5eaf874c8e09440/include/linux/kernel.h#L22-L38
I don't really plan to port all the features of the Zenfone 3, as I only own the ZE520KL_MP. Should I create 16 nodes, or just 2 nodes (ze520kl and ze552kl)?
There was a problem hiding this comment.
Please only add those you can verify working
(...) also I think most of the listed entries are prototypes/preprod models so there would be only two anyway available in retail. I'd guess MP means "mass prodution" and all other ones are various EVT/DVT/PVT
There was a problem hiding this comment.
ok I splitted them into two nodes based on the cmdline, wdyt?
There was a problem hiding this comment.
This looks good I think but please squash the commits
Actually, the mainline kernel needs this to identify the appropriate driver to use. Also split zenfone3 devices based on the cmdline
Smankusors
force-pushed
the
panel-zenfone3
branch
from
d9b1f35 to
59c3076
Compare
|
Thanks! |
2 participants
Actually, the mainline kernel needs this to identify the appropriate driver to use.