dts: msm8960: Add support for Sony Xperia SP (huashan) - #542
Conversation
|
My device is using GSBI8 as I2C, and also after applying this patch the GSBI8 is configured correctly to I2C by stock Android kernel. Not sure about other devices. |
|
|
||
| uart_dm_init(5, 0x16400000, 0x16440000); | ||
| break; | ||
| return uart_dm_init(5, 0x16400000, 0x16440000); |
There was a problem hiding this comment.
I think it's not typical to use "return " in functions with void type, can you leave this style the way it is?
There was a problem hiding this comment.
going to revert this since it negatively impacts expressatt
| }; | ||
| sony-huashan { | ||
| /* | ||
| * The display currently does not work due to lk2nd requiring MDP5, which is not available on the |
There was a problem hiding this comment.
lk2nd does also support MDP4, if the display was already enabled by the stock bootloader, so the justification here is a bit odd. What happens if you omit the ENABLE_DISPLAY=0? Ideally lk2nd should automatically detect that the display is not enabled.
There was a problem hiding this comment.
the lk2nd would hang waiting for the display
if I manually init the display clocks, it will not hang anymore though
| { | ||
| uart_dm_init(5, 0x16400000, 0x16440000); | ||
| switch (board_baseband()) { | ||
| case BASEBAND_MSM: |
There was a problem hiding this comment.
Are we sure this doesn't negatively affect any other devices? E.g. if Samsung devices use UART5 and Sony devices use UART8, then you are fixing Sony here but breaking Samsung.
Do you have UART accessible on your device? Or what are we fixing here?
There was a problem hiding this comment.
yes, I confirmed with the expressatt user that it broke their UART output. I'm going to revert this first
Signed-off-by: Antony K. S <postmarketos@smankusors.com>
Smankusors
changed the title
|
Thanks! |
4 participants
unfortunately this device has some quirks: