config/dtb: Add Asus Zenfone 3 (zenfone3) #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barni2000
requested changes
Aug 25, 2024
config/asus-zenfone3.sh
Outdated
|
|
||
| OPTIONS=(-r vsn -r vsp) | ||
| PANELS=( | ||
| [ctc5p5_ili7807b_1080p_video]="asus,ctc5p5_ili7807b" |
Member
There was a problem hiding this comment.
Suggested change
| [ctc5p5_ili7807b_1080p_video]="asus,ctc5p5_ili7807b" | |
| [ctc5p5_ili7807b_1080p_video]="asus,zs520kl-ili7807b-cts5p5" |
Author
There was a problem hiding this comment.
wait, what is this for?
btw "5p2" is for ze520kl, while "5p5" is for ze552kl
and the lk2nd PR for these panels was merged a month ago, do I need to open another PR to them? 😵💫
msm8916-mainline/lk2nd#392
Member
There was a problem hiding this comment.
You can update lk2nd, than use ze552kl and ze520kl prefix and remove the post fixes
Member
There was a problem hiding this comment.
or you can used postfixes without 5p5 and 5p2
Author
There was a problem hiding this comment.
hmm... wdyt about this commit? looks good?
Smankusors/lk2nd@8f33f76
config/asus-zenfone3.sh
Outdated
| [ctc5p5_ili7807b_1080p_video]="asus,ctc5p5_ili7807b" | ||
| [tm5p5_r63350_1080p_video]="asus,tm5p5_r63350" | ||
| [tm5p2_r63350_1080p_video]="asus,tm5p2_r63350" | ||
| [boe5p2_ili7807b_1080p_video]="asus,boe5p2_ili7807b" |
Member
There was a problem hiding this comment.
Suggested change
| [boe5p2_ili7807b_1080p_video]="asus,boe5p2_ili7807b" | |
| [boe5p2_ili7807b_1080p_video]="asus,zs520kl-ili7807b-boe5p2" |
config/asus-zenfone3.sh
Outdated
| [tm5p5_r63350_1080p_video]="asus,tm5p5_r63350" | ||
| [tm5p2_r63350_1080p_video]="asus,tm5p2_r63350" | ||
| [boe5p2_ili7807b_1080p_video]="asus,boe5p2_ili7807b" | ||
| [txd5p5_nt35596_1080p_video]="asus,txd5p5_nt35596" |
Member
There was a problem hiding this comment.
Suggested change
| [txd5p5_nt35596_1080p_video]="asus,txd5p5_nt35596" | |
| [txd5p5_nt35596_1080p_video]="asus,zs520kl-nt35596-txd5p5" |
config/asus-zenfone3.sh
Outdated
| [tm5p2_r63350_1080p_video]="asus,tm5p2_r63350" | ||
| [boe5p2_ili7807b_1080p_video]="asus,boe5p2_ili7807b" | ||
| [txd5p5_nt35596_1080p_video]="asus,txd5p5_nt35596" | ||
| [lce5p5_otm1901a_1080p_video]="asus,lce5p5_otm1901a" |
Member
There was a problem hiding this comment.
Suggested change
| [lce5p5_otm1901a_1080p_video]="asus,lce5p5_otm1901a" | |
| [lce5p5_otm1901a_1080p_video]="asus,zs520kl-otm1901a-lce5p5" |
config/asus-zenfone3.sh
Outdated
| OPTIONS=(-r vsn -r vsp) | ||
| PANELS=( | ||
| [ctc5p5_ili7807b_1080p_video]="asus,ctc5p5_ili7807b" | ||
| [tm5p5_r63350_1080p_video]="asus,tm5p5_r63350" |
Member
There was a problem hiding this comment.
Suggested change
| [tm5p5_r63350_1080p_video]="asus,tm5p5_r63350" | |
| [tm5p5_r63350_1080p_video]="asus,zs520kl-r63350-tm5p5" |
config/asus-zenfone3.sh
Outdated
| PANELS=( | ||
| [ctc5p5_ili7807b_1080p_video]="asus,ctc5p5_ili7807b" | ||
| [tm5p5_r63350_1080p_video]="asus,tm5p5_r63350" | ||
| [tm5p2_r63350_1080p_video]="asus,tm5p2_r63350" |
Member
There was a problem hiding this comment.
Suggested change
| [tm5p2_r63350_1080p_video]="asus,tm5p2_r63350" | |
| [tm5p2_r63350_1080p_video]="asus,zs520kl-r63350-tm5p2" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can only validate the
tm5p2_r63350_1080p_video, because it is the display my phone currently uses.Please let me know if there's anything else I need to do regarding this PR.