arm64: dts: msm8953: add zenfone3 device trees #211

Smankusors · 2024-08-25T14:21:37Z

so far only these are confirmed to work:

lcd
sdcard
wifi + bluetooth
touchscreen
audio
- ~~the speaker will only work when rebooting from the downstream kernel~~
- fixed with tfa9895
battery
- could not confirm 100% since my battery is broken now, would not charge to 100%
ramoops
- I aligned with the lk2nd, because the downstream kernel couldn't read it
modem
gps
cm3323e light sensor at the back

barni2000 · 2024-08-25T17:02:22Z

arch/arm64/boot/dts/qcom/msm8953-asus-common.dtsi

+		pm8953_l8: l8 {
+			regulator-min-microvolt = <2900000>;
+			regulator-max-microvolt = <2900000>;
+			regulator-always-on;


I think it is not needed at mainline because drivers will enable the regulators.

barni2000 · 2024-08-25T17:02:37Z

arch/arm64/boot/dts/qcom/msm8953-asus-common.dtsi

+		pm8953_l10: l10 {
+			regulator-min-microvolt = <3000000>;
+			regulator-max-microvolt = <3000000>;
+			regulator-always-on;


barni2000 · 2024-08-25T17:03:00Z

arch/arm64/boot/dts/qcom/msm8953-asus-common.dtsi

+		pm8953_l6: l6 {
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			// regulator-always-on;


barni2000 · 2024-08-25T17:03:09Z

arch/arm64/boot/dts/qcom/msm8953-asus-common.dtsi

+		pm8953_l3: l3 {
+			regulator-min-microvolt = <925000>;
+			regulator-max-microvolt = <925000>;
+			// regulator-allow-set-load; // seems to be no use


barni2000 · 2024-08-25T17:03:45Z

arch/arm64/boot/dts/qcom/msm8953-asus-common.dtsi

+	};
+};
+
+&i2c_6 {


If you don't use remove

barni2000 · 2024-08-25T17:04:05Z

arch/arm64/boot/dts/qcom/msm8953-asus-common.dtsi

+		interrupt-parent = <&tlmm>;
+		interrupts = <65 IRQ_TYPE_EDGE_FALLING>;
+
+		pinctrl-names = "default", "sleep";


pinctrl-names goes after pinctrl-n

barni2000 · 2024-08-25T17:04:19Z

arch/arm64/boot/dts/qcom/msm8953-asus-common.dtsi

+	status = "okay";
+};
+
+&i2c_2 {


barni2000 · 2024-08-25T17:05:13Z

arch/arm64/boot/dts/qcom/msm8953-asus-common.dtsi

+/ {
+	chassis-type = "handset";
+	qcom,board-id = <21 0>;
+	qcom,msm-id = <293 0>;


You can use QCOM_ID_MSM8953

barni2000 · 2024-08-25T17:06:18Z

arch/arm64/boot/dts/qcom/msm8953-asus-common.dtsi

+	};
+};
+
+&tlmm {


I think couple of pinctrls are pre defined in msm8953.dtsi please check them.

yes the gpio_key_default and sdc2_cd_on, what to do about them?

use them from msm8953.dtsi and remove from here

hmmm, I'm suprised that I didn't need these to work. The volume down and sdcard is still working 👀

alright removing...

barni2000 · 2024-09-24T15:55:35Z

Can you rebase it on 6.11/main please.

barni2000 · 2024-09-27T19:13:50Z

Please reword your commit message and add your signed-of-by.

Smankusors · 2024-09-28T02:43:49Z

Please reword your commit message and add your signed-of-by.

wait, what do you mean by "reword your commit message"? 😅

btw I'm planning to add a sensor that its driver already exist on the mainline. Please wait for a moment...

Signed-off-by: Antony K. S <postmarketos@smankusors.com>

commit 54b91e5 upstream. The way tracing_mark_raw_write() records its data is that it has the following structure: struct { struct trace_entry; int id; char buf[]; }; But memcpy(&entry->id, buf, size) triggers the following warning when the size is greater than the id: ------------[ cut here ]------------ memcpy: detected field-spanning write (size 6) of single field "&entry->id" at kernel/trace/trace.c:7458 (size 4) WARNING: CPU: 7 PID: 995 at kernel/trace/trace.c:7458 write_raw_marker_to_buffer.isra.0+0x1f9/0x2e0 Modules linked in: CPU: 7 UID: 0 PID: 995 Comm: bash Not tainted 6.17.0-test-00007-g60b82183e78a-dirty #211 PREEMPT(voluntary) Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.17.0-debian-1.17.0-1 04/01/2014 RIP: 0010:write_raw_marker_to_buffer.isra.0+0x1f9/0x2e0 Code: 04 00 75 a7 b9 04 00 00 00 48 89 de 48 89 04 24 48 c7 c2 e0 b1 d1 b2 48 c7 c7 40 b2 d1 b2 c6 05 2d 88 6a 04 01 e8 f7 e8 bd ff <0f> 0b 48 8b 04 24 e9 76 ff ff ff 49 8d 7c 24 04 49 8d 5c 24 08 48 RSP: 0018:ffff888104c3fc78 EFLAGS: 00010292 RAX: 0000000000000000 RBX: 0000000000000006 RCX: 0000000000000000 RDX: 0000000000000000 RSI: 1ffffffff6b363b4 RDI: 0000000000000001 RBP: ffff888100058a00 R08: ffffffffb041d459 R09: ffffed1020987f40 R10: 0000000000000007 R11: 0000000000000001 R12: ffff888100bb9010 R13: 0000000000000000 R14: 00000000000003e3 R15: ffff888134800000 FS: 00007fa61d286740(0000) GS:ffff888286cad000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000560d28d509f1 CR3: 00000001047a4006 CR4: 0000000000172ef0 Call Trace: <TASK> tracing_mark_raw_write+0x1fe/0x290 ? __pfx_tracing_mark_raw_write+0x10/0x10 ? security_file_permission+0x50/0xf0 ? rw_verify_area+0x6f/0x4b0 vfs_write+0x1d8/0xdd0 ? __pfx_vfs_write+0x10/0x10 ? __pfx_css_rstat_updated+0x10/0x10 ? count_memcg_events+0xd9/0x410 ? fdget_pos+0x53/0x5e0 ksys_write+0x182/0x200 ? __pfx_ksys_write+0x10/0x10 ? do_user_addr_fault+0x4af/0xa30 do_syscall_64+0x63/0x350 entry_SYSCALL_64_after_hwframe+0x76/0x7e RIP: 0033:0x7fa61d318687 Code: 48 89 fa 4c 89 df e8 58 b3 00 00 8b 93 08 03 00 00 59 5e 48 83 f8 fc 74 1a 5b c3 0f 1f 84 00 00 00 00 00 48 8b 44 24 10 0f 05 <5b> c3 0f 1f 80 00 00 00 00 83 e2 39 83 fa 08 75 de e8 23 ff ff ff RSP: 002b:00007ffd87fe0120 EFLAGS: 00000202 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 00007fa61d286740 RCX: 00007fa61d318687 RDX: 0000000000000006 RSI: 0000560d28d509f0 RDI: 0000000000000001 RBP: 0000560d28d509f0 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000202 R12: 0000000000000006 R13: 00007fa61d4715c0 R14: 00007fa61d46ee80 R15: 0000000000000000 </TASK> ---[ end trace 0000000000000000 ]--- This is because fortify string sees that the size of entry->id is only 4 bytes, but it is writing more than that. But this is OK as the dynamic_array is allocated to handle that copy. The size allocated on the ring buffer was actually a bit too big: size = sizeof(*entry) + cnt; But cnt includes the 'id' and the buffer data, so adding cnt to the size of *entry actually allocates too much on the ring buffer. Change the allocation to: size = struct_size(entry, buf, cnt - sizeof(entry->id)); and the memcpy() to unsafe_memcpy() with an added justification. Cc: stable@vger.kernel.org Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Cc: Andrew Morton <akpm@linux-foundation.org> Link: https://lore.kernel.org/20251011112032.77be18e4@gandalf.local.home Fixes: 64cf7d0 ("tracing: Have trace_marker use per-cpu data to read user space") Reported-by: syzbot+9a2ede1643175f350105@syzkaller.appspotmail.com Closes: https://lore.kernel.org/all/68e973f5.050a0220.1186a4.0010.GAE@google.com/ Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

barni2000 reviewed Aug 25, 2024

View reviewed changes

barni2000 requested changes Aug 25, 2024

View reviewed changes

Smankusors force-pushed the asus-zenfone3 branch from a179c9e to 98bd26d Compare August 25, 2024 18:40

barni2000 approved these changes Aug 25, 2024

View reviewed changes

Smankusors force-pushed the asus-zenfone3 branch 3 times, most recently from 7bd40c1 to c829a77 Compare September 16, 2024 16:13

barni2000 changed the base branch from 6.10/main to 6.11/main September 27, 2024 19:07

barni2000 changed the base branch from 6.11/main to 6.10/main September 27, 2024 19:08

Smankusors marked this pull request as draft September 28, 2024 02:43

arm64: dts: msm8953: add initial zenfone3 device trees

823bd63

Signed-off-by: Antony K. S <postmarketos@smankusors.com>

Smankusors changed the base branch from 6.10/main to 6.11/main September 28, 2024 15:53

Smankusors force-pushed the asus-zenfone3 branch from c829a77 to 823bd63 Compare September 28, 2024 15:54

Smankusors marked this pull request as ready for review September 28, 2024 15:56

barni2000 merged commit 6f272f9 into msm8953-mainline:6.11/main Sep 28, 2024

Smankusors deleted the asus-zenfone3 branch September 27, 2025 03:01

+              	};
+              };
+              &tlmm {

arm64: dts: msm8953: add zenfone3 device trees #211

arm64: dts: msm8953: add zenfone3 device trees #211

Uh oh!

Conversation

Smankusors commented Aug 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

barni2000 commented Sep 24, 2024

Uh oh!

barni2000 commented Sep 27, 2024

Uh oh!

Smankusors commented Sep 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Smankusors commented Aug 25, 2024 •

edited

Loading