Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regression in docker file according to best practices #80

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
2 participants
@msokk

This comment has been minimized.

Copy link
Owner

msokk commented Mar 7, 2019

Thanks, I'll try to get to bottom with build failure this weekend.

@msokk msokk merged commit bad1a6d into msokk:master Mar 7, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@msokk

This comment has been minimized.

Copy link
Owner

msokk commented Mar 7, 2019

I swapped out testing framework, but it looks like that PDF rendering has some race conditions in Electron v4 Linux, in some cases valid blank PDF is rendered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.