Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple ISSN #6

Closed
HemingNM opened this issue Aug 13, 2018 · 6 comments
Closed

Multiple ISSN #6

HemingNM opened this issue Aug 13, 2018 · 6 comments

Comments

@HemingNM
Copy link

@HemingNM HemingNM commented Aug 13, 2018

Olá Marcelo,

Estou tendo problemas com revistas que possuem múltiplos ISSNs.
Creio que se fizer duas modificações pode solucionar o problema (veja abaixo). Espero ter ajudado.
Abraço

  1. função "gld_get_SJR", remover linhas 82 a 84:
    df.sjr$Issn <- paste0(stringr::str_sub(df.sjr$Issn, 1, 4),
    '-',
    stringr::str_sub(df.sjr$Issn, 5, 8))

  2. função "gld_get_lattes_data",
    Linhas 84 e 94:
    substituir "idx <- match(tpublic.published$ISSN, df.sjr$Issn)" por:
    idx <- unlist(sapply(gsub("-", "", tpublic.published$ISSN),
    function(i, x){
    r <- grep(i, x)
    if(length(r) == 0){
    r <- NA
    }
    return(r)
    } , df.sjr$Issn, USE.NAMES=F))

Linha 87 e 98:
substituir "idx <- match(tpublic.accepted$ISSN, df.sjr$Issn)" por:
idx <- unlist(sapply(gsub("-", "", tpublic.accepted$ISSN),
function(i, x){
r <- grep(i, x)
if(length(r) == 0){
r <- NA
}
return(r)
} , df.sjr$Issn, USE.NAMES=F))

@HemingNM
Copy link
Author

@HemingNM HemingNM commented Aug 13, 2018

Não há necessidade de modificar as linhas 82 e 87.

@msperlin
Copy link
Owner

@msperlin msperlin commented Aug 13, 2018

Oi Heming,

Obrigado. Vou dar uma olhada assim que puder. Vou deixar aberto aqui o issue e assim que resolver aviso por aqui.

Abc.

@msperlin
Copy link
Owner

@msperlin msperlin commented Aug 13, 2018

Tu tens um id que eu possa testar?

@HemingNM
Copy link
Author

@HemingNM HemingNM commented Aug 13, 2018

K4781135T5

@msperlin
Copy link
Owner

@msperlin msperlin commented Aug 13, 2018

Ok, arrumado. Mudei algumas coisas no seu código para controlar alguns casos indesejáveis.

Nova versão no github.

Obrigado pela contribuição!

Abraço.

@msperlin msperlin closed this Aug 13, 2018
@HemingNM
Copy link
Author

@HemingNM HemingNM commented Aug 13, 2018

Maravilha! Funcionando perfeitamente, obrigado.

Abraço

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.