This repository has been archived by the owner on Feb 26, 2019. It is now read-only.
Search only for RD names #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although I think it is a good idea to extend the search to cities and also even for countries, this fix narrows down the search to RD names as originally intended.
|
I think this is the right fix for now. If we were highlighting the matched portion of the text, along with the city/state/country, then it would work correctly. But that's a bigger UI change. |
scottstanfield
pushed a commit
that referenced
this pull request
Oct 27, 2013
Search only for RD names
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although I think it is a good idea to extend the search to cities and also even for countries, this fix narrows down the search to RD names as originally intended.