New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support key+password authentication #112

Open
niklaas opened this Issue Jul 24, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@niklaas
Copy link

niklaas commented Jul 24, 2017

Could it be that key+password authentication is not supported? I imported my private key and tried to connect. I was asked for my password, so I entered it. Then I get the message:

"Failed to clone repository from [censored] to file:///private/var/mobile/Containers/Shared/AppGroup/[numbers]/Library/password-store-temp"

In my sshd_config I have:

AuthenticationMethods publickey,keyboard-interactive
@yishilin14

This comment has been minimized.

Copy link
Collaborator

yishilin14 commented Jul 27, 2017

Sorry for the late reply. I just did a testing, key+password authentication is supported (by ObjectiveGit we use).

  • The correct form of the URL should be ssh://git@gitlab.com/passforios-demo/demo.git and the username is git in this case. Please double check your inputs. [Wiki]
  • The TestFlight version is now providing more error messages about git cloning. If you want to join the iOS beta via Testflight, please drop an email to developer@passforios.mssun.me.
@niklaas

This comment has been minimized.

Copy link

niklaas commented Jul 27, 2017

No worries. Hm. On my server I only get

Jul 27 20:35:43 box-hlm-03 sshd[6677]: Connection closed by 95.116.183.164 port 53892 [preauth]

as if the key is not accepted. I'll drop an email to the address mentioned...

@mssun

This comment has been minimized.

Copy link
Owner

mssun commented Jul 28, 2017

@yishilin14, I think @niklaas 's question is whether we can use password and ssh key combination for authentication. Is that correct?

I guess we only support either password or ssh key authentication right now.

@yishilin14

This comment has been minimized.

Copy link
Collaborator

yishilin14 commented Jul 28, 2017

I was using SSH key with passphrase. Just to be clear.

@niklaas

This comment has been minimized.

Copy link

niklaas commented Jul 28, 2017

@mssun This is what I mean. I tried to make that clear by pasting part of my sshd_config. To login on my server, I require the client to first authenticate with an ssh key (can be password protected, needn't be -- I guess I cannot enforce that on the server side) and, when key authentication was successful, the user must provide their password.

Using the version provided via TestFlight, I get the following error message:

Failed to clone repository <some text> Underlying error: Invalid signature for supplied public key, or bad username/public key combination

I tried the very same private key from my notebook without problems. My impression is that you only support either password or key authentication. That's why authentication fails when I try to connect. If this is the case: Are there plans to support authentication that requires both?

@mssun

This comment has been minimized.

Copy link
Owner

mssun commented Jul 28, 2017

@niklaas

This comment has been minimized.

Copy link

niklaas commented Aug 2, 2017

No hurries, just in case you forgot about this because of Defcon: Any way to see this implemented? If not, I would need my pass git repo to a more unrestricted user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment