Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localise extensions by copying string bundle resources #254

Merged
merged 1 commit into from Mar 9, 2019

Conversation

Projects
None yet
2 participants
@davidjb
Copy link
Contributor

davidjb commented Mar 9, 2019

Previously, the Pass extensions (for autofill and for the sharing sheet) didn't see their strings being localised. This was visible if building from master but also in Testflight with v0.6.0 and its current build.

This means that in some cases, English was the only thing shown and in others strings would look like #EnterPasscode# (such as on the passcode lock screen; see Before below). This was because their build phases didn't reference the localised string files in the Copy Bundle Resources phase.

This PR adds the localisation files into this phase and thus the extensions are now localised and work in both English and German (eg the localisation languages to date). This change also removes duplication of passExtension/InfoPlist.strings which had the same strings as the one in pass/InfoPlist.strings; so this change just ensures the latter is copied in at build time.

Before:
Simulator Screen Shot - iPhone XR - before

After:
Simulator Screen Shot - iPhone XR - after

Localise extensions by copying bundle resources
Previously, the Pass extensions (for autofill and for the sharing sheet)
didn't see their strings being localised. This means that in some cases,
English was the only thing shown and in others strings would look like
`#EnterPasscode#` on the passcode lock screen.  This was because their
build phases didn't reference the localised string files in the `Copy
Bundle Resources` phase.

This change ensures these localisation files are copied and thus the
extensions are now localised for both English and German (so far).
@mssun

This comment has been minimized.

Copy link
Owner

mssun commented Mar 9, 2019

Thank you so much. I didn't notice this issue before.

@mssun mssun merged commit 1dfaf7c into mssun:master Mar 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@davidjb

This comment has been minimized.

Copy link
Contributor Author

davidjb commented Mar 9, 2019

@mssun I only just saw it when I was working on my recent PRs, building from master; I hadn't seen it before either. The issue isn't in an officially released version so perhaps it was related to #242. Other targets in the app might need adjustment too but in any case, both the extensions are now localised and happy 😄

@mssun

This comment has been minimized.

Copy link
Owner

mssun commented Mar 9, 2019

Yes, the current release on App Store is a little outdated. Normally, I will submit the latest build to the TestFlight channel after a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.