Decompress section data prior to use #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't matter for `.eh_frame`, but it does matter to dwarf data, which is often compressed. Accessing uncompressed data will result in a silent failure in `framehop`: * https://github.com/mstange/framehop/blob/v0.7.2/src/unwinder.rs#L575
Owner
|
Thanks! Yeah, the silent discarding of the error in framehop is not great. |
vvuk
pushed a commit
to vvuk/samply
that referenced
this pull request
Apr 24, 2024
vvuk
pushed a commit
to vvuk/samply
that referenced
this pull request
Apr 24, 2024
This notably enables Microsoft-Windows-Win32k which has struct properties which may have allowed us to catch issue mstange#10 in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't matter for
.eh_frame, but it does matter to dwarf data, which is often compressed. Accessing uncompressed data will result in a silent failure inframehop: