New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an intermediate file for asciidoc #104

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@bmwiedemann

bmwiedemann commented Sep 13, 2017

because asciidoc embeds the input file's mtime into the output html,
without this patch each package build produced a different result.

See https://reproducible-builds.org/ for why this matters.

Use an intermediate file for asciidoc
because asciidoc embeds the input file's mtime into the output html,
without this patch each package build produced a different result.

See https://reproducible-builds.org/ for why this matters.
@msteveb

This comment has been minimized.

Show comment
Hide comment
@msteveb

msteveb Sep 13, 2017

Owner

Thanks. I think I'll just take the brute force approach of removing the footer.
I don't know why asciidoc doesn't make the footer optional.

Owner

msteveb commented Sep 13, 2017

Thanks. I think I'll just take the brute force approach of removing the footer.
I don't know why asciidoc doesn't make the footer optional.

@msteveb msteveb closed this Sep 13, 2017

@bmwiedemann

This comment has been minimized.

Show comment
Hide comment
@bmwiedemann

bmwiedemann Sep 13, 2017

Unfortunately your grep -v does not do the trick because in more recent versions of asciidoc, those are two lines:

<div id="footer-text">
Last updated
 2014-02-06 01:33:28 UTC
</div>

bmwiedemann commented Sep 13, 2017

Unfortunately your grep -v does not do the trick because in more recent versions of asciidoc, those are two lines:

<div id="footer-text">
Last updated
 2014-02-06 01:33:28 UTC
</div>
@msteveb

This comment has been minimized.

Show comment
Hide comment
@msteveb

msteveb Sep 13, 2017

Owner

Thanks. What version of asciidoc?

Owner

msteveb commented Sep 13, 2017

Thanks. What version of asciidoc?

@msteveb msteveb reopened this Sep 13, 2017

@bmwiedemann

This comment has been minimized.

Show comment
Hide comment
@bmwiedemann

bmwiedemann Sep 13, 2017

having asciidoc-8.6.9 in openSUSE Tumbleweed from 2013-11-06

bmwiedemann commented Sep 13, 2017

having asciidoc-8.6.9 in openSUSE Tumbleweed from 2013-11-06

@bmwiedemann

This comment has been minimized.

Show comment
Hide comment
@bmwiedemann

bmwiedemann Sep 13, 2017

I guess, I could also push a more recent version of asciidoc which would solve this with https://github.com/asciidoc/asciidoc/blob/master/asciidoc.py#L1273

bmwiedemann commented Sep 13, 2017

I guess, I could also push a more recent version of asciidoc which would solve this with https://github.com/asciidoc/asciidoc/blob/master/asciidoc.py#L1273

@bmwiedemann

This comment has been minimized.

Show comment
Hide comment
@bmwiedemann

bmwiedemann Sep 13, 2017

actually the linebreak comes from asciidoc/asciidoc@9a2f59e which we backported to our package.

bmwiedemann commented Sep 13, 2017

actually the linebreak comes from asciidoc/asciidoc@9a2f59e which we backported to our package.

@msteveb

This comment has been minimized.

Show comment
Hide comment
@msteveb

msteveb Sep 13, 2017

Owner

OK, I've pushed a more robust fix. Let me know if that doesn't work for you.

Owner

msteveb commented Sep 13, 2017

OK, I've pushed a more robust fix. Let me know if that doesn't work for you.

@bmwiedemann

This comment has been minimized.

Show comment
Hide comment
@bmwiedemann

bmwiedemann Sep 13, 2017

68df14c could do the trick, if @Sed@ is working as intended (which it wasnt in 0.75)

bmwiedemann commented Sep 13, 2017

68df14c could do the trick, if @Sed@ is working as intended (which it wasnt in 0.75)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment