{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":797136517,"defaultBranch":"master","name":"asdcplib","ownerLogin":"mstorsjo","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2024-05-07T09:07:13.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69727?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1715072862.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"ffb6121b0d3503047e491316cff02c61868cf4b5","ref":"refs/heads/remove-broken-template","pushedAt":"2024-05-07T09:07:42.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mstorsjo","name":"Martin Storsjö","path":"/mstorsjo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/69727?s=80&v=4"},"commit":{"message":"Remove a broken, unused template class\n\nSince Clang changes\nhttps://github.com/llvm/llvm-project/pull/84050 and\nhttps://github.com/llvm/llvm-project/pull/90152 (upcoming in\nClang 19.x), Clang will diagnose member accesses before instantiating\nC++ templates.\n\nWithin the optional_container_property template, this causes errors\nfor the calls to this->Copy() and this->clear(), as there are no\ncorresponding methods within that template class, errors like these:\n\n    asdcplib/src/MXF.h:276:12: error: no member named 'Copy' in 'optional_container_property<PropertyType>'\n      276 |             this->Copy(rhs.m_property);\n          |             ~~~~  ^\n    asdcplib/src/MXF.h:284:48: error: no member named 'clear' in 'optional_container_property<PropertyType>'\n      284 |           void reset(const PropertyType& rhs) { this->clear(); }\n          |                                                 ~~~~  ^\n\nThis template is unused, and these faulty calls have been present\nsince the class was added in 02915821cfb49cb6851086f5d991cee58328102b.\n\nSimply remove the unused template class, to avoid these compiler\nerrors.\n\nThis fixes https://github.com/cinecert/asdcplib/issues/136.","shortMessageHtmlLink":"Remove a broken, unused template class"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEQ10HMAA","startCursor":null,"endCursor":null}},"title":"Activity · mstorsjo/asdcplib"}