New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Any::Moose with Moo/Type::Tiny #13

Merged
merged 1 commit into from Dec 31, 2015

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Dec 22, 2015

RT#104920 recommends that Any::Moose be replaced by Moo since
Any::Moose is deprecated. This set of changes implements this with a
combination of Moo and Type::Tiny. It was also necessary to make
process_tilde no longer a required attribute in order to keep the tests
passing (t/01-encoding.t complained about process_tilde being a missing
argument); from the code it looks like process_tilde doesn't have to be
necessary, hence the rationale for this particular change. This PR thus
addresses the issue in RT#104920.

Replace Any::Moose with Moo/Type::Tiny
RT#104920 recommends that `Any::Moose` be replaced by `Moo` since
`Any::Moose` is deprecated.  This set of changes implements this with a
combination of `Moo` and `Type::Tiny`.  It was also necessary to make
`process_tilde` no longer a required attribute in order to keep the tests
passing (`t/01-encoding.t` complained about `process_tilde` being a missing
argument); from the code it looks like `process_tilde` doesn't have to be
necessary, hence the rationale for this particular change.

mstratman added a commit that referenced this pull request Dec 31, 2015

@mstratman mstratman merged commit 3f1a22c into mstratman:master Dec 31, 2015

@paultcochrane paultcochrane deleted the paultcochrane:pr/replace-any-moose-with-moo branch Jan 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment