New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused constants #21

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Dec 31, 2015

The constants @GFI, @GFL and %POLY, defined in
Barcode::DataMatrix::Constants weren't actually used. These variables
were duplicated in Barcode::DataMatrix::Reed, which is where they were
used. Thus this commit removes the unused, duplicate entries in
Barcode::DataMatrix::Constants and moves the documentation about the
meaning of the constants in to Barcode::DataMatrix::Reed so that this
information doesn't get lost.

Remove unused constants
The constants `@gfi`, `@gfl` and `%POLY`, defined in
`Barcode::DataMatrix::Constants` weren't actually used.  These variables
were duplicated in `Barcode::DataMatrix::Reed`, which is where they were
used.  Thus this commit removes the unused, duplicate entries in
`Barcode::DataMatrix::Constants` and moves the documentation about the
meaning of the constants in to `Barcode::DataMatrix::Reed` so that this
information doesn't get lost.
@mstratman

This comment has been minimized.

Show comment
Hide comment
@mstratman

mstratman Jan 1, 2016

Owner

Implemented in c7b1f1e

Owner

mstratman commented Jan 1, 2016

Implemented in c7b1f1e

@mstratman mstratman closed this Jan 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment