-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bundle "set- cookie-parser" to prevent module resolution issues #65
Conversation
@@ -40,7 +40,8 @@ The `Headers` polyfill instance supports the same methods as the standard `Heade | |||
- [`.set()`](https://developer.mozilla.org/en-US/docs/Web/API/Headers/set) | |||
- [`.append()`](https://developer.mozilla.org/en-US/docs/Web/API/Headers/append) | |||
- [`.delete()`](https://developer.mozilla.org/en-US/docs/Web/API/Headers/delete) | |||
- `.forEach()` | |||
- [`.forEach()`](https://developer.mozilla.org/en-US/docs/Web/API/Headers/forEach) | |||
- [`.getSetCookie()`](https://developer.mozilla.org/en-US/docs/Web/API/Headers/getSetCookie) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just updating/adding these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome. Let's give this a try!
Released: v3.2.2 🎉This has been released in v3.2.2! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
fixes #62
Instead of externalizing
set-cookie-parser
which has noesm
shipped code, this bundles it into headers-polyfill - which should alleviate issues with non-esm environments and esm environments