Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(package): update typescript to v4.8 #1375

Merged
merged 5 commits into from
Aug 30, 2022
Merged

feat(package): update typescript to v4.8 #1375

merged 5 commits into from
Aug 30, 2022

Conversation

dargmuesli
Copy link
Contributor

@dargmuesli dargmuesli commented Aug 26, 2022 •
edited by kettanaito
Loading

@kettanaito kettanaito mentioned this pull request Aug 27, 2022
Closed
4 tasks
@kettanaito
Copy link
Member

Hey, @dargmuesli! Thanks for opening this. I've seen other developers requesting 4.8 support so this is definitely on our roadmap (see #1376). Let's see whether our current source code can compile on 4.8 without issues.

@dargmuesli
Copy link
Contributor Author

dargmuesli commented Aug 28, 2022 •
edited
Loading

Everyone: feel free to add/suggest the necessary changes for the builds to run successfully!
I've added ts 4.8 to the build matrix as well.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 29, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7d4f8d0:

Sandbox Source
MSW React Configuration

@dargmuesli
Copy link
Contributor Author

dargmuesli commented Aug 29, 2022 •
edited
Loading

Hey @kettanaito, I've resolved the typing issues I think. Has been fairly straight-forward, but maybe check if the array addition in https://github.com/mswjs/msw/pull/1375/files#diff-7b84dd6c401e1aad989a92df223139b02211125ef773060498e026b464c2b3c1R38 (in context/set) is ok this way 👋

@kettanaito
Copy link
Member

Hey, @dargmuesli. You are absolutely fantastic! 🎉 Will check that.

@dargmuesli
Copy link
Contributor Author

The dependency type-fest was outdated. Updated it, now the test compilation runs fine on my machine as well. Missed that before.

@kettanaito
Copy link
Member

Great find! Thanks. Let's see if these changes are also compatible with other versions of TypeScript we support 👀

Maybe we should establish a policy that adding a new version removes the oldest one automatically. We should have the fixed number of supported projects anyway to keep our heads sane. No need to do this now but something to consider.

@dargmuesli
Copy link
Contributor Author

Great, looks like all tests pass! 🥳

kettanaito
kettanaito approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A superb work done! Thank you, @dargmuesli. Welcome to contributors 🎉

@kettanaito kettanaito merged commit 631f629 into mswjs:main Aug 30, 2022
@dargmuesli dargmuesli deleted the feat/typescript-4.8 branch August 30, 2022 20:06
@kettanaito
Copy link
Member

Released: v0.46.0 🎉

This has been released in v0.46.0!

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.

Predictable release automation by @ossjs/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kettanaito kettanaito kettanaito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support TypeScript 4.8
2 participants
@dargmuesli @kettanaito