Browse files

sequencer: factor code out of revert builtin

Expose the cherry-picking machinery through a public
sequencer_pick_revisions() (renamed from pick_revisions() in
builtin/revert.c), so that cherry-picking and reverting are special
cases of a general sequencer operation.  The cherry-pick builtin is
now a thin wrapper that does command-line argument parsing before
calling into sequencer_pick_revisions().  In the future, we can write
a new "foo" builtin that calls into the sequencer like:

  memset(&opts, 0, sizeof(opts));
  opts.action = REPLAY_FOO;
  opts.revisions = xmalloc(sizeof(*opts.revs));
  parse_args_populate_opts(argc, argv, &opts);

This patch does not intend to make any functional changes.  Check

  $ git blame -s -C HEAD^..HEAD -- sequencer.c | grep -C3 '^[^^]'

Signed-off-by: Ramkumar Ramachandra <>
Reviewed-by: Jonathan Nieder <>
Signed-off-by: Junio C Hamano <>
  • Loading branch information...
1 parent 644a369 commit 043a4492b3b7da6496617201c369cff6ab7c26f2 @artagnon artagnon committed with gitster Jan 11, 2012
Showing with 956 additions and 947 deletions.
  1. +2 −946 builtin/revert.c
  2. +917 −1 sequencer.c
  3. +37 −0 sequencer.h
Oops, something went wrong.

0 comments on commit 043a449

Please sign in to comment.