Convert to forward slash before creating leading directory

[linquize]

Fix clone failure when target directory is C:\1\2 but C:\1 does not exist, using Windows Command Prompt

[buildhive]

MSysGit - the development behind Git for Windows » git #109 SUCCESS
This pull request looks good
(what's this?)

[dscho]

Sorry it took so long for somebody to look over this... but... would it not make more sense to teach safe_create_leading_directories to handle backslashes on Windows, too? I.e. something like

while (*pos && !is_dir_sep(*pos))
        pos++;
if (!*pos)
        break;

instead of

pos = strchr(pos, '/');
if (!pos)
        break;

at https://github.com/linquize/msysgit-git/blob/869e795d8f370386d1c63366f964ed27765d5a6a/sha1_file.c#L111

[sschuberth]

Indeed @dscho's proposal looks more elegant. Any objection that I try to take this upstream?

[dscho]

@sschuberth Do go ahead!

[dscho]

Since the proposed solution is superseded by my suggestion -- and since it is unclear that this change is needed in the first place -- I am closing this bug.

[linquize]

So, is the issue fixed?

[dscho]

@linquize no. It did not look to me as if you were still interested in it, so I closed it, especially after you did not react to my suggestion and after @sschuberth (who might, or might not, have time to work on it) agreed that the solution I proposed would be better.

[sschuberth]

The upstream patch / discussion is at http://www.spinics.net/lists/git/msg222459.html.