New Windows-style Git Logo #99

Closed
wants to merge 3 commits into
from

Projects

None yet

7 participants

@BaconRanch
Contributor

I have modified the icons and tested an installer build:

screen

For the installer sidebar image, I chose to enlarge the new Windows-style logo and exclude the "git" text, simply because I thought the yellow portion of the Windows style logo didn't contrast very well with the white background when set to a small size. I was also bothered by the fact that the bottom tip of the diamond didn't line up with the dot over the "i" in "git," even though the diamond was centered correctly. The "g" character is wide enough that it pushes the "i" and "t" over too much:
bad_image
Now that I see it here though, I kind of like it. If you prefer that I use this image for the installer, just let me know and I can update it.

Note that this also updates the icon on the Git Bash, Git Gui, and a variety of other tools included in Git for Windows.

As I mentioned earlier, the logo lacks contrast at small sizes, so I decided to add a dark background to the icon to make it more visible:

gbashdesktop

taskbar

So there you have it! Feel free to suggest any modifications!

@BaconRanch BaconRanch referenced this pull request in msysgit/git Feb 8, 2013
Closed

New msysGit / Git for Windows Logo #55

@sschuberth
Member

I must say now that I see the enlarged sidebar image without the "git" text I like that better than the original layout with the "git" text. There's not much need for repeating the "git" text as part of the image anyway, as the text to the right already says "Git" several times (and additionally, there's the upper / lower case conflict between "git" and "Git", so let's just stick to the latter).

I also like the dark background for the icon images. How about adding the dark background to the enlarged sidebar image, too?

@sschuberth
Member

BTW, you should not replace the "msysgitlogo.ico". It is not used by the installer anyway, and by leaving it as-is it's consistent with "msysgitlogo.svg".

@BaconRanch
Contributor

Glad you like the changes! I have reverted to the original msysgitlogo.ico and I added a dark background to the installer image. I also updated the screenshot in the PR post as well, so you can see how it looks.

@sschuberth
Member

Thanks! Let's see what others say before merging this. BTW, we probably need to pay some special attention to the order in which the different image resolutions are stored in the .ico file, see this commit, but I could handle that after merging.

@mcandre
mcandre commented Feb 13, 2013

It's not a bad visual design, however, its likeness to the XP-style Windows logo makes it easy to confuse with Microsoft-made software. I rather like the current orange msysGit logo and feel that its distinctness from most other programs is a valuable attribute.

@BaconRanch
Contributor

The logo does contain the familiar Windows- style colored squares, but it displays them in a diamond with a cutout of a visual representation of merging branches. The intent was to create a design that merged elements from both Windows and git. This visual "merging" represents a similar merging process that goes on in the adaption of a unix-style piece of software to the Windows operating system, which is what the Git for Windows project is all about.

On the topic of confusion, I would be surprised if any user technical enough to understand what git is would dare mistake it for a Microsoft product, but I understand your point. However, while it certainly looks more like a Microsoft product than the original git logo, I believe it is still distinct enough. It sits in a middle-ground, much like the project it represents.

@dscho
Member
dscho commented Feb 15, 2013

I agree, there is little danger of confusion. And it is a nice combination of the themes ''Git'' and ''Windows''. I like it.

@mcandre
mcandre commented Feb 15, 2013

@BaconRanch It's not a matter of skill or intelligence. This logo is almost exactly the Windows logo, rotated 45 degrees.

Furthermore, it's better to unify logos across platforms. This is known as branding. Would you prefer that Firefox for Windows had a Windows-like logo? Everything starts to look like Windows icons, and it becomes much slower to pick through them to find the one you want.

@dscho
Member
dscho commented Feb 15, 2013

@mcandre we have a good tradition in the Git for Windows project: you have to earn bitching rights. @BaconRanch made a suggestion. You are free to make a counter-proposal, and then you can start bitching.

Also, your reasoning about cross-platform branding appears to me as less than convincing. There have been two competing Git logos already for a long time. Then GitHub made a third (arguably better one, if you ever studied what makes a logo good). We switched to using that, so basically there are three Git logos now (so much for branding). And then @BaconRanch played on that GitHub theme rather competently.

So I challenge you to produce a better logo.

@mcandre
mcandre commented Feb 15, 2013

@dscho Apologies. Counter proposal: The orange one here is perfect, let's use that. A platform-specific logo is silly.

@koraktor

Additionally, it seems that Microsoft switched from the colored logo to a monochrome logo for Windows 8. Only Microsoft's own logo has the four well-known colors. I guess it's not a good idea to link Git (or msysGit) to Microsoft's CI.

@dscho
Member
dscho commented Feb 15, 2013

Guys, what is the problem? First, bitching rights need to be earned. That has been repeated in this thread for your benefit. Second, what is wrong with saying that this is Git for Windows by combining one of the three Git logos with something people associate with Windows?

Seriously. Unless there are waaaay better objections, I am strongly in favor of going with @BaconRanch's proposal.

@svnpenn
Member
svnpenn commented May 3, 2013

As part of the organization I should have bitching rights 😊
I am with the dissenters, Firefox logo is the same across all platforms. Git should not be different.

@sschuberth
Member

I had also given this some thought when the discussion was still hot. While I still like the new logo quite a lot (and I do not think it makes Git look too much like a Microsoft product) I agree that it breaks the holistic UI experience across platforms. And as I believe maintaining the UI experience is a stronger argument that having a nice (but otherwise not necessary) new logo, I'm going to close the pull request for good.

@dscho If you feel strongly otherwise feel free to reopen, but I don't think we will get an new arguments given how long this discussion already is unresolved.

@BaconRanch Please don't feel sad about this decision. In any case your logos are already committed to

https://github.com/msysgit/msysgit/tree/master/share/resources

as git_windows*.svg.

@sschuberth sschuberth closed this May 3, 2013
@BaconRanch
Contributor

It's fine. Thanks anyway!

@dscho
Member
dscho commented May 25, 2013

@BaconRanch Since I liked your logo, I was a bit sad that the outcome of the discussion was to leave the logo at its original (I can understand the reasoning, though).

However, I think that there is some project that you might want to work on, and I would be incredibly grateful if you did: our home page needs some TLC. (A couple of months ago, @xpaulbettsx offered some help by GitHub for our home page, but at this point I am slightly tired of waiting, but conscious enough of my limitations in graphical design to avoid trying my own hand at it).

So: would this be something you'd enjoy, overhaul http://msysgit.github.com/?

@BaconRanch
Contributor

@dscho Yes, I would be happy to come up with a redesign for the page. I have a fair amount of experience in web design and, as a college student on summer break, I have some free time to work on it too. Would you want me to work with the content that's currently on the page or did you have ideas as to different content to display for the new site? I ask because I noticed "Stay tuned, this page will have more information later!" at the bottom of the current site.
Thank you for the opportunity by the way!

@dscho
Member
dscho commented May 26, 2013

@BaconRanch great! Since you have experience with web design (and I have experience how to s*ck at web design), I think it would not make much sense for me to tell you what I'd like you to do -- apart from my desire for a sexier home page for the Git for Windows project.

The comment "stay tuned" dates back from February 2012 when I still was under the impression that a new design (in line with the GitHub CI) was imminent.

So: go wild!

@BaconRanch
Contributor

@dscho Sounds good! I've got some ideas and will come up with a design over the next few days.

@BaconRanch
Contributor

I thought I'd post a preview of what I have so far on the new site design. It lacks some content so far, but it should give you an idea. I think its turning out very well:

http://dl.dropboxusercontent.com/u/40538551/gwhtml/index.html

Just in case something goes horribly wrong with the preview due to a cross browser incompatibility that I'm not yet aware of, here's a screenshot of what I see in Firefox 21:

http://dl.dropboxusercontent.com/u/40538551/gwindows.png

@dscho
Member
dscho commented Jun 2, 2013

@BaconRanch that looks very nice! How about forking https://github.com/msysgit/msysgit.github.com and making a pull request there?

@dscho
Member
dscho commented Jun 2, 2013

(Previews would still be easy through this cool site...)

@sschuberth
Member

@BaconRanch I agree this looks very nice! Some minor suggestions from my side:

  • Since commit "Documentation: the name of the system is 'Git', not 'git'" upstream writes "Git" when meaning the system, and "git" only in examples for command line usage. I think we should do the same and usually write "Git" and "Git for Windows".
  • Please use "SCM" instead of "VCS" as its more common in the Git context and better fits the git-scm.com web site.
  • It would be nice if the inside of the Git logo would be transparent instead of white. As the web site's background is light gray it should still look good, I guess.
  • If "Develop" is supposed to link to the msysgit stuff we should probably make more clear that "Develop" does not mean "develop with Git" but "work on Git itself". So how about naming it "Contribute" instead?
@sschuberth
Member

PS: Hehe, I like that little hover effect of the Git logo ;-)

@dscho
Member
dscho commented Jun 2, 2013

How about using the term "SDK" instead of "Develop" (I think the idea was @hvoigt's, originally)?

@hvoigt
Member
hvoigt commented Jun 3, 2013

@dscho well I stole SDK from other tools. I think on window this term is quite common. Thats why I used it, so windows developers directly get what we mean. How about using a descriptive text link like we now do on the main page? I think the contribution part should not be as prominent as the download part on the main page because the truth is: More people are going to download than contribute.

I think having a second page with some explanations how, where and what to contribute, like we now do, helps a lot.

@sschuberth
Member

I find "SDK" a bit unusual in this context. I believe that term is more commonly used for some API to use, not for a development environment like we are providing. Thus, I still vote for "Contribute" :-)

@svnpenn
Member
svnpenn commented Jun 3, 2013

@sschuberth I agree. Its best to avoid acronyms just for "looking cool", unless they are really needed. 👍 for Contribute

@hvoigt
Member
hvoigt commented Jun 4, 2013

Well what are we talking about here? The download link for the msysgit development environment or the link to the separate page? I would not put the download to the devel environment on the first page without any explanation. So as I wrote before I think "Contribute" is fine but I would like to have more there like: Report Bugs, Have Problems, ... That way everyone who has something to tell is lead to the explanation page first. Contribute sounds like you need to know what you want to do and people might not consider the explanation of a problem they are having as a contribution. Having multiple ways (in this case words) to find something is good because different people also have different ways of thinking.

@hvoigt
Member
hvoigt commented Jun 4, 2013

BTW besides the discussion how we should link to the contribution part I really like the design and think that we should just go with it as soon as we have something complete.

@BaconRanch
Contributor

@sschuberth Ok, so I've made the logo transparent and used "SCM" in the title instead of "VCS." Easy fixes. As far as the capitalization of "Git" goes, I decided to follow git-scm.com and capitalize all references of the word on the page except for the header at the top of the page. I understand the point about the software being called "Git" officially, but I think the lowercase "g" is so recognizable it's practically iconic now. Also, I use "Git" everywhere in HTML and simply style the lowercase in CSS, so search engines will parse it with correct capitalization. As a result, we're usually using the capitalized version and only lowercasing for "recognizability." The dropbox link to the site has been updated with these changes.

As for the blue section covering the bottom half of the page, it currently contains a "So what's Git?" section with no content (yet). This would serve as a brief introduction to Git that provided a link to git-scm.com.

We could have a second section that described the main tools and features of Git for Windows. Things like the bash and gui, as well as diff tools.

Finally, we could have a "Contributing to Git for Windows" section that solved the problem @hvoigt mentioned of needing an explanation of things like bug reporting & problems as well as a link to the msysGit distribution for coders. The "Develop" button (which I have renamed to "Contribute") at the top of the page would simply link to this section.

I will make a pull request and add in this content over the next few days. Oh! And I'm glad you guys like it! :)

@sschuberth
Member

@hvoigt I also think we should be talking about the link to a separate page because neither "SDK" nor "Contribute" would be enough explanation for what to do with and msysgit download. In fact I think "Contribute" should just link to the GitHub project page, and the direct link to the repository should be removed form the header. To me "Contribute" could also mean to just report (good and concise) bug reports, and it's probably not a bad idea to "hide" the bug tracker behind a "Contribute" link because this will make sure only people who really are willing to contribute click there.

Maybe even the "Downloads" link should be removed from the header. We already have a "Download" button for the latest version, and for the sake of reducing version fragmentation we should encourage to download the latest version only. The links to the wiki and mailing list should IMHO stay.

@BaconRanch I agree that it makes sense to keep "git" in lower case where its use is part of a logo / iconic.

@BaconRanch
Contributor

The site design is done! Check out the latest on the dropbox link! At this point, we're looking at some CSS cleanup and revision of the site's text content. I'll make a fork and a pull request within the next 24 hours and we'll work on final revisions there.

@dscho
Member
dscho commented Jun 20, 2013

@BaconRanch great news! Although I'd like to suggest to use Git from the beginning next time, not at the very end (which kinda defeats Git's purpose).

@BaconRanch
Contributor

Yes, I understand. Sorry about that. It was a simple enough project that missing code revisions / history isn't a huge deal though.

@dscho
Member
dscho commented Jun 21, 2013

@BaconRanch not for you, it isn't a problem. I could not follow the development, could not see what was changing, could not contribute. If that's what you wanted, I guess it's fine.

@BaconRanch
Contributor

I have forked and committed to msysgit.github.com. Note that I tried to use the repository preview tool: htmlpreview.github.io. However, it does not seem to load SVG images or custom fonts, so the site looks pretty terrible when viewed through the preview tool. As a test, I created baconranch.github.io and committed the same files. Everything worked fine.

I apologize for not creating the fork sooner. I did not realize that you may have wanted to contribute to the design as it was being created. Maybe I worded my previous few posts poorly. When I said the site design was done, I meant that I had completed my idea for an initial design. The site can certainly be modified further and there's no reason we can't begin to collaborate at this stage on both content and style.

@BaconRanch BaconRanch referenced this pull request in msysgit/msysgit.github.com Jun 23, 2013
Closed

msysgit.github.com Site Redesign #8

@BaconRanch
Contributor

@sschuberth @dscho
It has been more than a week and nothing has happened on the PR. I can understand if you're busy but when do you think you'll have time to look at this?

@sschuberth
Member

@BaconRanch Most of us have only time once a week at the weekend for msysGit, and if something else blocks the weekend a review can easily take two weeks. That said I've taken another look at the PR, and I'll put my comments directly there.

@BaconRanch
Contributor

@sschuberth I'll take a look at your feedback and make revisions. Many thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment