Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build errors. #1

Merged
merged 1 commit into from Jul 22, 2016
Merged

Fixed build errors. #1

merged 1 commit into from Jul 22, 2016

Conversation

jayjaybillings
Copy link
Contributor

Updated bundles to address compilation errors. Moved explicit
require-bundle statements to import-package statements to mess with
Eclipse RAP support. Regenerated model code to catch latest updates.

Signed-off-by: Jay Jay Billings billingsjj@ornl.gov

Updated bundles to address compilation errors. Moved explicit
require-bundle statements to import-package statements to mess with
Eclipse RAP support. Regenerated model code to catch latest updates.

Signed-off-by: Jay Jay Billings <billingsjj@ornl.gov>
@jayjaybillings
Copy link
Contributor Author

I was playing with Texo and had some trouble getting the web example and RCP bundles to build. I fixed some errors and regenerated various pieces of code to get it to work, so I wanted to share that with you.

In case it helps in your decision making on taking this pull request, I am the project lead for Eclipse ICE and Eclipse EAVP. (Nice to meet you, btw!)

@mtaal mtaal merged commit 23d3c02 into mtaal:master Jul 22, 2016
@mtaal
Copy link
Owner

mtaal commented Jul 22, 2016

Hi Jay Jay,
Yes I see your name several times on the mailing list. Thanks for the contribution appreciate it!
gr. Martin

@jayjaybillings
Copy link
Contributor Author

You're welcome!

From my phone.


From: Martin Taal
Sent: Friday, July 22, 2016 4:52 PM
To: mtaal/texo
CC: "Billings, Jay Jay" ,Author
Subject: Re: [mtaal/texo] Fixed build errors. (#1)

Hi Jay Jay,
Yes I see your name several times on the mailing list. Thanks for the contribution appreciate it!
gr. Martin

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//pull/1#issuecomment-234653366, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGFVYXAXODA9UeJue-9ouluFTZDh-vbbks5qYS2CgaJpZM4I1v5N.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants